Re: [RFC PATCH 0/6] Add gentle alternative for `get_oid()`

2018-07-18 Thread Paul-Sebastian Ungureanu
Hello, On 17.07.2018 20:45, Duy Nguyen wrote: Since get_oid() callers must handle failure when it returns non-zero, I would say "gently" is already implied by get_oid() and we could just convert those die() to error() or warning(). Unless some of those die() are very special that we need to

Re: [RFC PATCH 0/6] Add gentle alternative for `get_oid()`

2018-07-17 Thread Duy Nguyen
On Tue, Jul 17, 2018 at 2:10 PM Paul-Sebastian Ungureanu wrote: > > At the moment, `get_oid()` might call `die()` in some cases. To > prevent that from happening, this patches introduces a new flag > called `GET_OID_GENTLY` and a new function `get_oid_gently()`, > which passes the mentioned flag

[RFC PATCH 0/6] Add gentle alternative for `get_oid()`

2018-07-17 Thread Paul-Sebastian Ungureanu
At the moment, `get_oid()` might call `die()` in some cases. To prevent that from happening, this patches introduces a new flag called `GET_OID_GENTLY` and a new function `get_oid_gently()`, which passes the mentioned flag further to `get_oid_with_context()`. The call graph of `get_oid()` is