Re: [RFC PATCH 00/19] Bring more repository handles into our code base

2018-10-12 Thread Stefan Beller
On Fri, Oct 12, 2018 at 11:50 AM Jonathan Nieder wrote: > > It appears that some patches use a the_index-style > NO_THE_REPOSITORY_COMPATIBILITY_MACROS backward compatibility synonym > and others don't. Can you say a little more about this aspect of the > approach? Would the compatibility macro

Re: [RFC PATCH 00/19] Bring more repository handles into our code base

2018-10-12 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > This applies on nd/the-index (b3c7eef9b05) and is the logical continuation of > the object store series, which I sent over the last year. > > The previous series did take a very slow and pedantic approach, > using a #define trick, see cfc62fc98c for details, but it turn

Re: [RFC PATCH 00/19] Bring more repository handles into our code base

2018-10-11 Thread Junio C Hamano
Stefan Beller writes: > Additionally each patch adds a semantic patch, that would port from the old to > the new function. These semantic patches are all applied in the very last > patch, > but we could omit applying the last patch if it causes too many merge > conflicts > and trickl in the sem

Re: [RFC PATCH 00/19] Bring more repository handles into our code base

2018-10-11 Thread Jonathan Tan
> This series takes another approach as it doesn't change the signature of > functions, but introduces new functions that can deal with arbitrary > repositories, keeping the old function signature around using a shallow > wrapper. > > Additionally each patch adds a semantic patch, that would por

[RFC PATCH 00/19] Bring more repository handles into our code base

2018-10-11 Thread Stefan Beller
This applies on nd/the-index (b3c7eef9b05) and is the logical continuation of the object store series, which I sent over the last year. The previous series did take a very slow and pedantic approach, using a #define trick, see cfc62fc98c for details, but it turns out, that it doesn't work: When