On Thu, Feb 8, 2018 at 1:06 AM, Stefan Beller wrote:
>> Something else.. maybe "struct repository *" should not be a universal
>> function argument to avoid global states. Like sha1_file.c is mostly about
>> the
>> object store, and I see that you added object store struct
On Mon, Feb 5, 2018 at 3:51 PM, Stefan Beller wrote:
> This series moves a lot of global state into the repository struct.
> It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
> It can be found at https://github.com/stefanbeller/git/tree/object-store
>
>
On Wed, Feb 7, 2018 at 3:48 AM, Duy Nguyen wrote:
> On Tue, Feb 6, 2018 at 6:51 AM, Stefan Beller wrote:
>> This series moves a lot of global state into the repository struct.
>> It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
>> It
On 2/5/2018 6:51 PM, Stefan Beller wrote:
This series moves a lot of global state into the repository struct.
It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
It can be found at https://github.com/stefanbeller/git/tree/object-store
Motivation for this series:
* Easier to
On Tue, Feb 6, 2018 at 6:51 AM, Stefan Beller wrote:
> This series moves a lot of global state into the repository struct.
> It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
> It can be found at https://github.com/stefanbeller/git/tree/object-store
>
>
On Tue, Feb 6, 2018 at 3:25 PM, Stefan Beller wrote:
>> Any suggestions welcome!
>
> Eric repeatedly points out leaking memory.
>
> As of today we do not care about memory leaking as it is cleaned
> up at the end of the program anyway, for example the objects
> hash table is
It took some time to do fixes in such a long series, mostl of my time spent in
rebasing and being extra careful about selecting the right commit to edit.
Based on feedback so far I have queued the changes below.
The changes are also available at
> Any suggestions welcome!
Eric repeatedly points out leaking memory.
As of today we do not care about memory leaking as it is cleaned
up at the end of the program anyway, for example the objects
hash table is never cleared.
In a resend I will put the infrastructure in place to free the memory
On Mon, Feb 05, 2018 at 03:51:54PM -0800, Stefan Beller wrote:
> This series moves a lot of global state into the repository struct.
> It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
> It can be found at https://github.com/stefanbeller/git/tree/object-store
>
> Motivation
On Mon, Feb 5, 2018 at 3:51 PM, Stefan Beller wrote:
>
> Any suggestions welcome!
>
I wouldn't say sending out this many patches is a smooth experience:
* After trying it out internally, it stopped at patch ~80 and the rate
limiter kicked in.
* Okay fine, I'll rate limit
This series moves a lot of global state into the repository struct.
It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
It can be found at https://github.com/stefanbeller/git/tree/object-store
Motivation for this series:
* Easier to reason about code when all state is stored in
11 matches
Mail list logo