Re: [RFC PATCH 1/5] packfile: make get_delta_base() non static

2018-07-27 Thread Jeff King
On Tue, Jul 24, 2018 at 09:19:27AM -0700, Junio C Hamano wrote: > Christian Couder writes: > > > From: Jeff King > > > > As get_delta_base() will be used outside 'packfile.c' in > > a following commit, let's make it non static and let's > > declare it in 'packfile.h'. > > As a public function

Re: [RFC PATCH 1/5] packfile: make get_delta_base() non static

2018-07-24 Thread Junio C Hamano
Christian Couder writes: > From: Jeff King > > As get_delta_base() will be used outside 'packfile.c' in > a following commit, let's make it non static and let's > declare it in 'packfile.h'. As a public function in *.h, don't we want a bit of comment there to help those who want to use it from

[RFC PATCH 1/5] packfile: make get_delta_base() non static

2018-07-21 Thread Christian Couder
From: Jeff King As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.h | 3 +++ 2 files changed, 8