On 29.04.16 02:43, Mike Hommey wrote:
> get_host_and_port(&ssh_host, &port);
> + if (!port)
> + port = get_port(ssh_host);
I'm not sure, if this is an improvement or not.
The original intention was, to check what the parser did, before
going out to
Junio C Hamano writes:
> Mike Hommey writes:
>
>> Signed-off-by: Mike Hommey
>
> I feel that this commit is under-explained. I think you should feel
> entitled to boast the goodness this brings to us louder in the log
> message.
>
> It bothers me somewhat that this ended up copying, not moving
Mike Hommey writes:
> Signed-off-by: Mike Hommey
I feel that this commit is under-explained. I think you should feel
entitled to boast the goodness this brings to us louder in the log
message.
It bothers me somewhat that this ended up copying, not moving, a bit
of code to call get-host-and-po
Signed-off-by: Mike Hommey
---
connect.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
Note this makes http://marc.info/?l=git&m=146183714532394 irrelevant.
diff --git a/connect.c b/connect.c
index 29569b3..ce216cb 100644
--- a/connect.c
+++ b/connect.c
@@
4 matches
Mail list logo
