Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-12 Thread Brandon Williams
On 10/11, Josh Triplett wrote: > On Tue, Oct 10, 2017 at 11:39:21AM -0700, Stefan Beller wrote: > > On Tue, Oct 10, 2017 at 6:03 AM, Heiko Voigt wrote: > > > but in the long run my goal > > > for submodules is and always was: Make them behave as close to files as > > >

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-11 Thread Junio C Hamano
Heiko Voigt writes: > This "default" value thing got me thinking in a different direction. We > could use a scheme like that to get names (and values) for submodules > that are missing from the .gitmodules file. If we decide that we need to > handle them. Yes, I suspect that

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-11 Thread Josh Triplett
On Tue, Oct 10, 2017 at 11:39:21AM -0700, Stefan Beller wrote: > On Tue, Oct 10, 2017 at 6:03 AM, Heiko Voigt wrote: > > but in the long run my goal > > for submodules is and always was: Make them behave as close to files as > > possible. And why should a 'git add submodule'

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-11 Thread Heiko Voigt
On Wed, Oct 11, 2017 at 08:31:37AM +0900, Junio C Hamano wrote: > Stefan Beller writes: > > > So you propose to make git-add behave like "git submodule add" > > (i.e. also add the .gitmodules entry for name/path/URL), which I > > like from a submodule perspective. > > > >

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-11 Thread Heiko Voigt
On Tue, Oct 10, 2017 at 11:39:21AM -0700, Stefan Beller wrote: > So you propose to make git-add behave like "git submodule add" > (i.e. also add the .gitmodules entry for name/path/URL), which I > like from a submodule perspective. Well more like: clone and add will behave like "git submodule

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-10 Thread Junio C Hamano
Junio C Hamano writes: > A few questions that come to mind are: > > - Does "git add sub/" have enough information to populate >.gitmodules? If we have reasonable "default" values for >.gitmodules entries (e.g. missing URL means we won't fetch when >asked to go

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-10 Thread Stefan Beller
On Tue, Oct 10, 2017 at 4:31 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> So you propose to make git-add behave like "git submodule add" >> (i.e. also add the .gitmodules entry for name/path/URL), which I >> like from a submodule perspective. >>

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-10 Thread Junio C Hamano
Stefan Beller writes: > So you propose to make git-add behave like "git submodule add" > (i.e. also add the .gitmodules entry for name/path/URL), which I > like from a submodule perspective. > > However other users of gitlinks might be confused[1], which is why > I refrained

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-10 Thread Stefan Beller
On Tue, Oct 10, 2017 at 6:03 AM, Heiko Voigt wrote: >> > As mentioned in the cover letter. This seems to be the only test that >> > ensures that we stay compatible with setups without .gitmodules. Maybe >> > we should add/revive some? >> >> An interesting discussion covering

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-10 Thread Heiko Voigt
Hi, On Mon, Oct 09, 2017 at 11:20:51AM -0700, Stefan Beller wrote: > On Fri, Oct 6, 2017 at 3:32 PM, Heiko Voigt wrote: > > NOTE: The argument in this message is not correct, see description in > > cover letter. > > > > The setup of the repositories in this test is using

Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-09 Thread Stefan Beller
On Fri, Oct 6, 2017 at 3:32 PM, Heiko Voigt wrote: > NOTE: The argument in this message is not correct, see description in > cover letter. > > The setup of the repositories in this test is using gitlinks without the > .gitmodules infrastructure. It is however testing

[RFC PATCH 2/4] change submodule push test to use proper repository setup

2017-10-06 Thread Heiko Voigt
NOTE: The argument in this message is not correct, see description in cover letter. The setup of the repositories in this test is using gitlinks without the .gitmodules infrastructure. It is however testing convenience features like --recurse-submodules=on-demand. These features are already not