Re: [RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-07-27 Thread Johannes Schindelin
Hi Eric, On Thu, 26 Jul 2018, Eric Sunshine wrote: > On Thu, Jul 26, 2018 at 6:56 AM Johannes Schindelin > wrote: > > On Tue, 17 Jul 2018, Eric Sunshine wrote: > > > On Tue, Jul 17, 2018 at 6:31 AM Johannes Schindelin > > > wrote: > > > > BTW I like to have an extra space in front of all the

Re: [RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-07-26 Thread Eric Sunshine
On Thu, Jul 26, 2018 at 6:56 AM Johannes Schindelin wrote: > On Tue, 17 Jul 2018, Eric Sunshine wrote: > > On Tue, Jul 17, 2018 at 6:31 AM Johannes Schindelin > > wrote: > > > BTW I like to have an extra space in front of all the range-diff lines, to > > > make it easier to discern them from the

Re: [RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-07-26 Thread Johannes Schindelin
Hi Eric, On Tue, 17 Jul 2018, Eric Sunshine wrote: > On Tue, Jul 17, 2018 at 6:31 AM Johannes Schindelin > wrote: > > On Wed, 30 May 2018, Eric Sunshine wrote: > > > > + if (range_diff) { > > > + struct argv_array ranges = ARGV_ARRAY_INIT; > > > +

Re: [RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-07-17 Thread Eric Sunshine
Thanks for the review comments. In the new version of the series (almost complete), almost the entire implementation has changed, including most of the stuff on which you commented. Anyhow, see my responses to your comments below... On Tue, Jul 17, 2018 at 6:31 AM Johannes Schindelin wrote: > On

Re: [RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-07-17 Thread Johannes Schindelin
Hi Eric, On Wed, 30 May 2018, Eric Sunshine wrote: > diff --git a/builtin/log.c b/builtin/log.c > index e01a256c11..460c31a293 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -28,6 +28,7 @@ > #include "mailmap.h" > #include "gpg-interface.h" > #include "progress.h" > +#include

[RFC PATCH 2/5] format-patch: add --range-diff option to embed diff in cover letter

2018-05-30 Thread Eric Sunshine
When submitting a revised version of a patch series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of an interdiff or range-diff, however, doing so involves manually copy/pasting the diff into the cover letter. Add a --range-diff option to