Re: [RFC PATCH 3/4] color.ui config: don't die on unknown values

2018-05-31 Thread Jeff King
On Thu, May 31, 2018 at 09:17:41AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Ævar Arnfjörð Bjarmason writes: > > > >> Before this change git will die on any unknown color.ui values: > >> > >> $ git -c color.ui=doesnotexist show > >> fatal: bad numeric config value 'doesnotexist' for

Re: [RFC PATCH 3/4] color.ui config: don't die on unknown values

2018-05-31 Thread Ævar Arnfjörð Bjarmason
On Wed, May 30 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Before this change git will die on any unknown color.ui values: >> >> $ git -c color.ui=doesnotexist show >> fatal: bad numeric config value 'doesnotexist' for 'color.ui': invalid >> unit > > I do not

Re: [RFC PATCH 3/4] color.ui config: don't die on unknown values

2018-05-30 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Before this change git will die on any unknown color.ui values: > > $ git -c color.ui=doesnotexist show > fatal: bad numeric config value 'doesnotexist' for 'color.ui': invalid > unit I do not think "unit" is correct, so there may be some room for

Re: [RFC PATCH 3/4] color.ui config: don't die on unknown values

2018-05-30 Thread Stefan Beller
On Wed, May 30, 2018 at 2:06 PM, Ævar Arnfjörð Bjarmason wrote: > Before this change git will die on any unknown color.ui values: > > $ git -c color.ui=doesnotexist show > fatal: bad numeric config value 'doesnotexist' for 'color.ui': invalid > unit > > This makes the failure mode of

[RFC PATCH 3/4] color.ui config: don't die on unknown values

2018-05-30 Thread Ævar Arnfjörð Bjarmason
Before this change git will die on any unknown color.ui values: $ git -c color.ui=doesnotexist show fatal: bad numeric config value 'doesnotexist' for 'color.ui': invalid unit This makes the failure mode of introducing any new values in the future really bad, as explained in the