[RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations

2018-09-05 Thread SZEDER Gábor
't1700-split-index.sh' checks that the index was split correctly under various circumstances and that all the different ways to turn the split index feature on and off work correctly. To do so, most of its tests use 'test-tool dump-split-index' to see which files have their cache entries in the sp

Re: [RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, SZEDER Gábor wrote: > +# Create a file named as $1 with content read from stdin. > +# Set the file's mtime to a few seconds in the past to avoid racy situations. > +create_file () { Nit: Would be easier to read in the future as e.g. s/create_file/create_old_file/ or somethi

Re: [RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations

2018-09-06 Thread SZEDER Gábor
On Thu, Sep 06, 2018 at 10:02:43AM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Sep 06 2018, SZEDER Gábor wrote: > > > +# Create a file named as $1 with content read from stdin. > > +# Set the file's mtime to a few seconds in the past to avoid racy > > situations. > > +create_file () { > >

Re: [RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, SZEDER Gábor wrote: > On Thu, Sep 06, 2018 at 10:02:43AM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Thu, Sep 06 2018, SZEDER Gábor wrote: >> >> > +# Create a file named as $1 with content read from stdin. >> > +# Set the file's mtime to a few seconds in the past to avo