Re: [RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-06-03 Thread Junio C Hamano
Derrick Stolee writes: >>> several reasons. Instead of doing the hard thing to fix those >>> interactions, instead prevent reading or writing a commit-graph file for >>> shallow repositories. >> The latter instead would want to vanish, I would guess. > > Do you mean that we should call

Re: [RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-06-02 Thread Jakub Narebski
Derrick Stolee writes: > On 5/31/2018 10:30 PM, Junio C Hamano wrote: >> Derrick Stolee writes: >> >>> Shallow clones do not interact well with the commit-graph feature for >>> several reasons. Instead of doing the hard thing to fix those >>> interactions, instead prevent reading or writing a

Re: [RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-06-01 Thread Derrick Stolee
On 5/31/2018 10:30 PM, Junio C Hamano wrote: Derrick Stolee writes: Shallow clones do not interact well with the commit-graph feature for several reasons. Instead of doing the hard thing to fix those interactions, instead prevent reading or writing a commit-graph file for shallow

Re: [RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-05-31 Thread Junio C Hamano
Derrick Stolee writes: > Shallow clones do not interact well with the commit-graph feature for > several reasons. Instead of doing the hard thing to fix those > interactions, instead prevent reading or writing a commit-graph file for > shallow repositories. The latter instead would want to

Re: [RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-05-31 Thread Stefan Beller
On Thu, May 31, 2018 at 10:41 AM, Derrick Stolee wrote: > Shallow clones do not interact well with the commit-graph feature for > several reasons. Instead of doing the hard thing to fix those > interactions, instead prevent reading or writing a commit-graph file for > shallow repositories. Makes

[RFC PATCH 4/6] commit-graph: avoid writing when repo is shallow

2018-05-31 Thread Derrick Stolee
Shallow clones do not interact well with the commit-graph feature for several reasons. Instead of doing the hard thing to fix those interactions, instead prevent reading or writing a commit-graph file for shallow repositories. Signed-off-by: Derrick Stolee --- commit-graph.c | 12