Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-10 Thread Paul-Sebastian Ungureanu
Hello, On 06.09.2018 20:53, Ævar Arnfjörð Bjarmason wrote: On Thu, Sep 06 2018, Ævar Arnfjörð Bjarmason wrote: On Thu, Sep 06 2018, SZEDER Gábor wrote: On Thu, Sep 06, 2018 at 02:26:49PM +0200, Ævar Arnfjörð Bjarmason wrote: On Thu, Sep 06 2018, SZEDER Gábor wrote: Several tests failed

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-08 Thread Duy Nguyen
On Thu, Sep 6, 2018 at 4:48 AM SZEDER Gábor wrote: > > Ever since the split index feature was introduced [1], refreshing a > split index is prone to a variant of the classic racy git problem. > > Consider the following sequence of commands updating the split index > when the shared index contains

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread SZEDER Gábor
On Thu, Sep 06, 2018 at 07:53:41PM +0200, Ævar Arnfjörð Bjarmason wrote: > I got 436 OK runs with that and 3 failures before I gave up and ctrl+c'd > it. And the 3 failures were: > > t3903-stash.sh (Wstat: 256 Tests: 90 Failed: 1) > Failed test: 55 > Non-zero exit

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, Ævar Arnfjörð Bjarmason wrote: > On Thu, Sep 06 2018, SZEDER Gábor wrote: > >> On Thu, Sep 06, 2018 at 02:26:49PM +0200, Ævar Arnfjörð Bjarmason wrote: >>> >>> On Thu, Sep 06 2018, SZEDER Gábor wrote: >>> > Several tests failed occasionally when the test suite was run with

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, SZEDER Gábor wrote: > On Thu, Sep 06, 2018 at 02:26:49PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Thu, Sep 06 2018, SZEDER Gábor wrote: >> > Several tests failed occasionally when the test suite was run with >> > 'GIT_TEST_SPLIT_INDEX=yes'. Here are those that I

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread SZEDER Gábor
On Thu, Sep 06, 2018 at 02:26:49PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Sep 06 2018, SZEDER Gábor wrote: > > Several tests failed occasionally when the test suite was run with > > 'GIT_TEST_SPLIT_INDEX=yes'. Here are those that I managed to trace > > back to this racy split index

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, SZEDER Gábor wrote: > Ever since the split index feature was introduced [1], refreshing a > split index is prone to a variant of the classic racy git problem. > > Consider the following sequence of commands updating the split index > when the shared index contains a racily

Re: [RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, SZEDER Gábor wrote: > t3903-stash.sh: > https://travis-ci.org/git/git/jobs/385542084#L5858 > > t4024-diff-optimize-common.sh: > https://travis-ci.org/git/git/jobs/386531969#L3174 > > t4015-diff-whitespace.sh: >

[RFC PATCH 5/5] split-index: smudge and add racily clean cache entries to split index

2018-09-05 Thread SZEDER Gábor
Ever since the split index feature was introduced [1], refreshing a split index is prone to a variant of the classic racy git problem. Consider the following sequence of commands updating the split index when the shared index contains a racily clean cache entry, i.e. an entry whose cached stat