Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-07 Thread Jeff King
On Thu, Jun 07, 2018 at 08:15:16PM -0700, Lars Schneider wrote: > > In fact, this patch probably should give the user some advice in that > > regard (either in the documentation, or as a warning when we skip the > > rejection). If you _do_ have a bogus credential and set the new option, > > you'd

Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-07 Thread Lars Schneider
> On 04 Jun 2018, at 11:55, Jeff King wrote: > > On Mon, Jun 04, 2018 at 12:18:59PM -0400, Martin-Louis Bright wrote: > >> Why must the credentials must be deleted after receiving the 401 (or >> any) error? What's the rationale for this? > > Because Git only tries a single credential per

Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-04 Thread Jeff King
On Mon, Jun 04, 2018 at 12:18:59PM -0400, Martin-Louis Bright wrote: > Why must the credentials must be deleted after receiving the 401 (or > any) error? What's the rationale for this? Because Git only tries a single credential per invocation. So if a helper provides one, it doesn't prompt. If

Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-04 Thread Martin-Louis Bright
Why must the credentials must be deleted after receiving the 401 (or any) error? What's the rationale for this? On Mon, Jun 4, 2018 at 10:47 AM, Jeff King wrote: > On Mon, Jun 04, 2018 at 05:26:35AM -0700, lars.schnei...@autodesk.com wrote: > >> From: Lars Schneider >> >> If a Git HTTP server

Re: [RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-04 Thread Jeff King
On Mon, Jun 04, 2018 at 05:26:35AM -0700, lars.schnei...@autodesk.com wrote: > From: Lars Schneider > > If a Git HTTP server responds with 401 or 407, then Git tells the > credential helper to reject and delete the credentials. In general > this is good. > > However, in certain automation

[RFC PATCH v1] http: add http.keepRejectedCredentials config

2018-06-04 Thread lars . schneider
From: Lars Schneider If a Git HTTP server responds with 401 or 407, then Git tells the credential helper to reject and delete the credentials. In general this is good. However, in certain automation environments it is not desired to remove credentials automatically. This is in particular the