Re: [RFC PATCH v2 01/12] submodule: add a print_config_from_gitmodules() helper

2018-08-09 Thread Antonio Ospite
On Thu, 2 Aug 2018 11:05:02 -0700 Stefan Beller wrote: > On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite wrote: > > [...] > > +extern int print_config_from_gitmodules(const char *key); > > The only real pushback for this patch I'd have is lack of documentation > in public functions, though this

Re: [RFC PATCH v2 01/12] submodule: add a print_config_from_gitmodules() helper

2018-08-02 Thread Stefan Beller
On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite wrote: > > This will be used to print values just like "git config -f .gitmodules" > would. > > Signed-off-by: Antonio Ospite > --- > submodule-config.c | 25 + > submodule-config.h | 2 ++ > 2 files changed, 27

[RFC PATCH v2 01/12] submodule: add a print_config_from_gitmodules() helper

2018-08-02 Thread Antonio Ospite
This will be used to print values just like "git config -f .gitmodules" would. Signed-off-by: Antonio Ospite --- submodule-config.c | 25 + submodule-config.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/submodule-config.c b/submodule-config.c index