Re: [RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up

2018-08-09 Thread Antonio Ospite
On Thu, 2 Aug 2018 11:15:03 -0700 Stefan Beller wrote: > On Thu, Aug 2, 2018 at 9:41 AM SZEDER Gábor wrote: > > [...] > > > > > > Note that test_when_finished is not used here, both to keep the current > > > style > > > and also because it does not work in sub-shells. > > > > That's true, but I

Re: [RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up

2018-08-02 Thread Junio C Hamano
SZEDER Gábor writes: >> Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with >> invalid lines in .gitmodules but then only the second commit is removed. >> >> This may affect future subsequent tests if they assume that the >> .gitmodules file has no errors. >> >> Since those commit

Re: [RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up

2018-08-02 Thread Stefan Beller
On Thu, Aug 2, 2018 at 9:41 AM SZEDER Gábor wrote: > > > Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with > > invalid lines in .gitmodules but then only the second commit is removed. > > > > This may affect future subsequent tests if they assume that the > > .gitmodules file has n

Re: [RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up

2018-08-02 Thread SZEDER Gábor
> Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with > invalid lines in .gitmodules but then only the second commit is removed. > > This may affect future subsequent tests if they assume that the > .gitmodules file has no errors. > > Since those commits are not needed anymore remov

[RFC PATCH v2 03/12] t7411: be nicer to future tests and really clean things up

2018-08-02 Thread Antonio Ospite
Tests 5 and 8 in t/t7411-submodule-config.sh add two commits with invalid lines in .gitmodules but then only the second commit is removed. This may affect future subsequent tests if they assume that the .gitmodules file has no errors. Since those commits are not needed anymore remove both of them