Re: [RFC PATCH v2 4/4] fetch: do not list refs if fetching only hashes

2018-09-28 Thread Jonathan Tan
> > + /* > > +* We can avoid listing refs if all of them are exact > > +* OIDs > > +*/ > > + must_list_refs = 0; > > + for (i = 0; i < rs->nr; i++) { > > + if (!rs->items[i].exact_sha1)

Re: [RFC PATCH v2 4/4] fetch: do not list refs if fetching only hashes

2018-09-27 Thread Stefan Beller
On Thu, Sep 27, 2018 at 12:24 PM Jonathan Tan wrote: > > If only hash literals are given on a "git fetch" command-line, tag > following is not requested, and the fetch is done using protocol v2, a > list of refs is not required from the remote. Therefore, optimize by > invoking

[RFC PATCH v2 4/4] fetch: do not list refs if fetching only hashes

2018-09-27 Thread Jonathan Tan
If only hash literals are given on a "git fetch" command-line, tag following is not requested, and the fetch is done using protocol v2, a list of refs is not required from the remote. Therefore, optimize by invoking transport_get_remote_refs() only if we need the refs. Signed-off-by: Jonathan Tan