Re: [RFC PATCH v2 5/5] builtin/branch: give more useful error messages when renaming

2017-10-23 Thread Kaartic Sivaraam
On Mon, 2017-10-23 at 12:44 -0700, Stefan Beller wrote: > +static void get_error_msg(struct strbuf* error_msg, const char* oldname, > unsigned old_branch_exists, > > + const char* newname, int > > new_branch_validation_result) > > nit here and in the return of

Re: [RFC PATCH v2 5/5] builtin/branch: give more useful error messages when renaming

2017-10-23 Thread Stefan Beller
On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam wrote: > builtin/branch.c | 41 +++-- > 1 file changed, 35 insertions(+), 6 deletions(-) The code of 4 and 5 looks good to me, though a small nit below. Thanks, Stefan > +static

[RFC PATCH v2 5/5] builtin/branch: give more useful error messages when renaming

2017-09-25 Thread Kaartic Sivaraam
When trying to rename an inexistent branch to with a name of a branch that already exists the rename failed specifying the new branch name exists rather than specifying that the branch trying to be renamed doesn't exist. $ git branch -m tset master fatal: A branch named 'master' already