Re: [RFC PATCH v3.1 2/9 2/2] rebase-interactive: Do not automatically run code

Wink Saville writes: > Currently I'm not rebasing the other commits (3..9) > to reduce the amount of work I have to do in each > review cycle, is that OK? Yeah, I want to see others more heavily involved in this part of the system to comment on your patches. As to the

Re: [RFC PATCH v3.1 2/9 2/2] rebase-interactive: Do not automatically run code

On Thu, Mar 22, 2018 at 1:46 PM, Junio C Hamano wrote: > Wink Saville writes: > >> At Junio's suggestion have git-rebase--am and git-rebase--merge work the >> same way as git-rebase--interactive. This makes the code more consistent. > > I mumbled about making

Re: [RFC PATCH v3.1 2/9 2/2] rebase-interactive: Do not automatically run code

Wink Saville writes: > At Junio's suggestion have git-rebase--am and git-rebase--merge work the > same way as git-rebase--interactive. This makes the code more consistent. I mumbled about making git_rebase__$type functions for all $type in my previous response, but that was

[RFC PATCH v3.1 2/9 2/2] rebase-interactive: Do not automatically run code

At Junio's suggestion have git-rebase--am and git-rebase--merge work the same way as git-rebase--interactive. This makes the code more consistent. Signed-off-by: Wink Saville --- git-rebase--am.sh | 17 ++--- git-rebase--interactive.sh | 8 +++-