Re: [RFC PATCH v4] Implement --first-parent for git rev-list --bisect

2018-05-28 Thread Junio C Hamano
Tiago Botelho writes: >> Running this test number of times gives me spurious errors. Is the >> order of these output lines unstable? How do we "sort" these >> bisect-all results? If we are not sorting and the output depends on >> happenstance, then probably we would need to compare the

Re: [RFC PATCH v4] Implement --first-parent for git rev-list --bisect

2018-05-28 Thread Tiago Botelho
On 28 May 2018 at 15:25, Junio C Hamano wrote: > Tiago Botelho writes: > > This will enable users to implement bisecting on first parents > > which can be useful for when the commits from a feature branch > > that we want to merge are not always tested. > > > > Signed-off-by: Tiago Botelho >

Re: [RFC PATCH v4] Implement --first-parent for git rev-list --bisect

2018-05-28 Thread Junio C Hamano
Tiago Botelho writes: > This will enable users to implement bisecting on first parents > which can be useful for when the commits from a feature branch > that we want to merge are not always tested. > > Signed-off-by: Tiago Botelho > --- > >

Re: [RFC PATCH v4] Implement --first-parent for git rev-list --bisect

2018-05-28 Thread Junio C Hamano
Tiago Botelho writes: > diff --git a/bisect.c b/bisect.c > index 4eafc8262..e58cb8d62 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -33,6 +33,8 @@ static const char *term_good; > * > * We care just barely enough to avoid recursing for > * non-merge entries. > + * >

[RFC PATCH v4] Implement --first-parent for git rev-list --bisect

2018-05-28 Thread Tiago Botelho
This will enable users to implement bisecting on first parents which can be useful for when the commits from a feature branch that we want to merge are not always tested. Signed-off-by: Tiago Botelho --- This patch adds all Junio's suggestions, namely