Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

On Fri, Mar 23, 2018 at 5:01 PM, Junio C Hamano wrote: > Eric Sunshine writes: >> (despite the run-on sentence in the first paragraph and the apparent >> incorrect explanation of top-level "return" misbehavior -- the in-code >> comment says top-level

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

On Fri, Mar 23, 2018 at 1:51 PM, Junio C Hamano wrote: > Wink Saville writes: > >> Here is one possibility: >> >> git format-patch --cover-letter --rfc --thread -v 5 >> --to=git@vger.kernel.org --cc=sunsh...@sunshineco.com >> --cc=johannes.schinde...@gmx.de

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Eric Sunshine writes: >> When it was discovered that some shell implementations > ... > ECANTPARSE: This paragraph is grammatically corrupt. > > ECANTPARSE: Grammatically corrupt. > ... > (despite the run-on sentence in the first paragraph and the apparent > incorrect

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Wink Saville writes: > Here is one possibility: > > git format-patch --cover-letter --rfc --thread -v 5 > --to=git@vger.kernel.org --cc=sunsh...@sunshineco.com > --cc=johannes.schinde...@gmx.de -o patches/v5 master..v5-2 Sounds sensible. > If this was the first version then

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

On Fri, Mar 23, 2018 at 10:12 AM, Johannes Schindelin wrote: > Hi Wink, > > On Thu, 22 Mar 2018, Wink Saville wrote: > >> The backend scriptlets for "git rebase" were structured in a >> bit unusual way for historical reasons. Originally, it was >> designed in such a

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Hi Wink, On Thu, 22 Mar 2018, Wink Saville wrote: > The backend scriptlets for "git rebase" were structured in a > bit unusual way for historical reasons. Originally, it was > designed in such a way that dot-sourcing them from "git > rebase" would be sufficient to invoke the specific backend. >

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Thanks for splitting these changes into smaller, more manageable chunks. A couple non-code comments below apply to both patches in this 2-patch series even though I'm responding only to this patch. (The actual code changes in the other patch looked fine and the patch was easily digested.) On Fri,

[RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

The backend scriptlets for "git rebase" were structured in a bit unusual way for historical reasons. Originally, it was designed in such a way that dot-sourcing them from "git rebase" would be sufficient to invoke the specific backend. When it was discovered that some shell implementations (e.g.