Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-08-03 Thread Ævar Arnfjörð Bjarmason
On Fri, Aug 03 2018, Phillip Wood wrote: [snip (all made sense)] > It seems clear for your comment and Junio's that I need to improve the > documentation, I'm not sure if that will be enough though or do we need > to change the behavior? [I'm beginning to see why all the other programs > I

Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-08-03 Thread Junio C Hamano
Phillip Wood writes: > ... [I'm beginning to see why all the other programs I tried while > writing this (tig, gitg, gitk and mercurial's version of add -i) > don't make any attempt to stage modified lines correctly, though I > think git should have some way of doing it.] Yes, this is a kind of

Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-08-03 Thread Phillip Wood
Hi Ævar Thanks for looking at this. On 28/07/18 13:40, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jul 26 2018, Phillip Wood wrote: > >> Unfortuantely v4 had test failures due to a suprious brace from a last >> minute edit to a comment that I forgot to test. This version fixes >> that, my

Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-07-28 Thread Ævar Arnfjörð Bjarmason
On Thu, Jul 26 2018, Phillip Wood wrote: > Unfortuantely v4 had test failures due to a suprious brace from a last > minute edit to a comment that I forgot to test. This version fixes > that, my applogies for the patch churn. > > I've updated this series based on Ævar's feedback on v3 (to

Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-07-28 Thread Phillip Wood
On 27/07/18 19:27, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jul 26 2018, Phillip Wood wrote: > >> From: Phillip Wood >> >> Unfortuantely v4 had test failures due to a suprious brace from a last >> minute edit to a comment that I forgot to test. This version fixes >> that, my applogies for the

Re: [RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-07-27 Thread Ævar Arnfjörð Bjarmason
On Thu, Jul 26 2018, Phillip Wood wrote: > From: Phillip Wood > > Unfortuantely v4 had test failures due to a suprious brace from a last > minute edit to a comment that I forgot to test. This version fixes > that, my applogies for the patch churn. > > I've updated this series based on Ævar's

[RFC PATCH v5 0/4] add -p: select individual hunk lines

2018-07-26 Thread Phillip Wood
From: Phillip Wood Unfortuantely v4 had test failures due to a suprious brace from a last minute edit to a comment that I forgot to test. This version fixes that, my applogies for the patch churn. I've updated this series based on Ævar's feedback on v3 (to paraphrase stop using '$_' so much and