[RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-15 Thread Stefan Beller
This is the beginning of the rewrite of the repacking. * Removed unneeded system header files * corrected remove_pack to really remove any pack files with the given sha1 * fail if pack-objects fails * Only test t7701 (2nd) fails now with this patch. Signed-off-by: Stefan Beller --- Make

Re: [RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-17 Thread René Scharfe
This is the beginning of the rewrite of the repacking. * Removed unneeded system header files * corrected remove_pack to really remove any pack files with the given sha1 * fail if pack-objects fails * Only test t7701 (2nd) fails now with this patch. Signed-off-by: Stefan Beller --- M

Re: [RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-17 Thread Kyle J. McKay
On Aug 17, 2013, at 06:34, René Scharfe wrote: On Aug 15, 2013, at 17:12, Stefan Beller wrote: + if (sha_begin >= e->d_name && !strncmp(sha_begin, sha1, 40)) { + char *fname; + fname = xmalloc(strlen(path) + 1 + strlen(e->d_name)); This

Re: [RFC PATCHv2] repack: rewrite the shell script in C.

2013-08-18 Thread Stefan Beller
On 08/17/2013 03:34 PM, René Scharfe wrote: > > Hmm, stepping back a bit, why not just build the paths and call unlink > for them right away, without readdir? The shell version only ever > deletes existing .pack files (those in $existing alias existing_packs) > as well as their .idx and .keep fil