Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-06-01 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: On 06/01/2015 02:16 AM, Matthieu Moy wrote: Karthik Nayak karthik@gmail.com writes: That is kind of a problem, If I need to swap those commits also, I'd have to add the part where ref-filter is added to the Makefile with the code movement

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: That is kind of a problem, If I need to swap those commits also, I'd have to add the part where ref-filter is added to the Makefile with the code movement from for-each-ref to ref-filter. This again will not just be Code movement. You can have a

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Karthik Nayak
On 06/01/2015 02:16 AM, Matthieu Moy wrote: Karthik Nayak karthik@gmail.com writes: That is kind of a problem, If I need to swap those commits also, I'd have to add the part where ref-filter is added to the Makefile with the code movement from for-each-ref to ref-filter. This again will

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Christian Couder
On Sun, May 31, 2015 at 10:50 PM, Karthik Nayak karthik@gmail.com wrote: On 06/01/2015 02:16 AM, Matthieu Moy wrote: You can have a preparatory patch that adds ref-filter.c containing just #include ref-filter.h and ref-filter.h with proper content. After this preparatory patch, you're in

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Karthik Nayak
On 05/31/2015 09:13 AM, Eric Sunshine wrote: On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote: Create 'ref-filter.h', also add ref-filter to the Makefile. This completes movement of creation of 'ref-filter' from 'for-each-ref'. It's important that the project can be

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Christian Couder
On Sat, May 30, 2015 at 7:53 PM, Karthik Nayak karthik@gmail.com wrote: -struct ref_sort { - struct ref_sort *next; - int atom; /* index into used_atom array */ Where is this used_atom array? I searched but couldn't find it in the same file. - unsigned reverse : 1;

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Karthik Nayak
On 05/31/2015 01:59 PM, Eric Sunshine wrote: On Sun, May 31, 2015 at 4:19 AM, Karthik Nayak karthik@gmail.com wrote: On 05/31/2015 09:13 AM, Eric Sunshine wrote: On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote: Create 'ref-filter.h', also add ref-filter to the

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Karthik Nayak
On 05/31/2015 01:50 PM, Christian Couder wrote: On Sat, May 30, 2015 at 7:53 PM, Karthik Nayak karthik@gmail.com wrote: -struct ref_sort { - struct ref_sort *next; - int atom; /* index into used_atom array */ Where is this used_atom array? I searched but couldn't find it in

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-31 Thread Eric Sunshine
On Sun, May 31, 2015 at 4:19 AM, Karthik Nayak karthik@gmail.com wrote: On 05/31/2015 09:13 AM, Eric Sunshine wrote: On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote: Create 'ref-filter.h', also add ref-filter to the Makefile. This completes movement of creation

[WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-30 Thread Karthik Nayak
Create 'ref-filter.h', also add ref-filter to the Makefile. This completes movement of creation of 'ref-filter' from 'for-each-ref'. Mentored-by: Christian Couder christian.cou...@gmail.com Mentored-by: Matthieu Moy matthieu@grenoble-inp.fr Signed-off-by: Karthik Nayak karthik@gmail.com

Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'

2015-05-30 Thread Eric Sunshine
On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak karthik@gmail.com wrote: Create 'ref-filter.h', also add ref-filter to the Makefile. This completes movement of creation of 'ref-filter' from 'for-each-ref'. It's important that the project can be built successfully and function correctly at