Re: [WIP/PATCH v5 02/10] for-each-ref: clean up code

2015-06-08 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: In 'grab_single_ref()' remove the extra count variable 'cnt' and use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly instead. Change comment in 'struct ref_sort' to reflect changes in code. I don't see how the comment change is

Re: [WIP/PATCH v5 02/10] for-each-ref: clean up code

2015-06-08 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: I put these two together as they are trivial changes. Either I could reword the commit message or split the commit. I'd split the commit. Actually, even though it's only a small comment change, it's not so trivial in the sense that one needs a good

[WIP/PATCH v5 02/10] for-each-ref: clean up code

2015-06-06 Thread Karthik Nayak
In 'grab_single_ref()' remove the extra count variable 'cnt' and use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly instead. Change comment in 'struct ref_sort' to reflect changes in code. Mentored-by: Christian Couder christian.cou...@gmail.com Mentored-by: Matthieu Moy