Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-05 Thread Jeff King
On Tue, Feb 05, 2013 at 05:21:18PM +0100, Michael J Gruber wrote: > Thanks Jeff, that helps a lot! It covers "grep expr" and "grep expr rev > -- path" just fine. I'll look into "grep expr rev:path" which does not > work yet because of an empty driver. > > I also have "show --textconv" covered and

Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-05 Thread Michael J Gruber
Jeff King venit, vidit, dixit 05.02.2013 12:13: > On Mon, Feb 04, 2013 at 04:27:31PM +0100, Michael J Gruber wrote: > >> Recently and not so recently, we made sure that log/grep type operations >> use textconv filters when a userfacing diff would do the same: >> >> ef90ab6 (pickaxe: use textconv f

Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-05 Thread Jeff King
On Mon, Feb 04, 2013 at 04:27:31PM +0100, Michael J Gruber wrote: > Recently and not so recently, we made sure that log/grep type operations > use textconv filters when a userfacing diff would do the same: > > ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28) > b1c2f57 (diff_grep: use t

Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-05 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 04.02.2013 18:12: > Michael J Gruber writes: > >> Recently and not so recently, we made sure that log/grep type operations >> use textconv filters when a userfacing diff would do the same: >> >> ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28) >> b1c2

Re: [WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-04 Thread Junio C Hamano
Michael J Gruber writes: > Recently and not so recently, we made sure that log/grep type operations > use textconv filters when a userfacing diff would do the same: > > ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28) > b1c2f57 (diff_grep: use textconv buffers for add/deleted files, 20

[WIP/RFH/RFD/PATCH] grep: allow to use textconv filters

2013-02-04 Thread Michael J Gruber
Recently and not so recently, we made sure that log/grep type operations use textconv filters when a userfacing diff would do the same: ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28) b1c2f57 (diff_grep: use textconv buffers for add/deleted files, 2012-10-28) 0508fe5 (combine-diff: res