Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

Hi Ævar and Eric, On Fri, 15 Mar 2019, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Mar 15 2019, Eric Sunshine wrote: > > > On Fri, Mar 15, 2019 at 12:09 PM Ævar Arnfjörð Bjarmason > > wrote: > >> diff --git a/Documentation/git-format-patch.txt > >> b/Documentation/git-format-patch.txt > >> @@ -2

Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

Eric Sunshine writes: > So, I'm fairly negative on this change. However, that doesn't mean I > would oppose tweaking the value shared between the two programs (and > also the default used by GitGitGadget, if it specifies it manually), > though I defer to Dscho in that regard. I do not think of a

Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

On Fri, Mar 15 2019, Eric Sunshine wrote: > On Fri, Mar 15, 2019 at 12:09 PM Ævar Arnfjörð Bjarmason > wrote: >> diff --git a/Documentation/git-format-patch.txt >> b/Documentation/git-format-patch.txt >> @@ -261,6 +261,10 @@ material (this may change in the future). >> +Defaults to 90, whereas

Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

On Fri, Mar 15, 2019 at 12:09 PM Ævar Arnfjörð Bjarmason wrote: > diff --git a/Documentation/git-format-patch.txt > b/Documentation/git-format-patch.txt > @@ -261,6 +261,10 @@ material (this may change in the future). > +Defaults to 90, whereas the linkgit:git-range-diff[1] default is > +60. It's

[WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

I just submittted https://public-inbox.org/git/20190315155959.12390-1-ava...@gmail.com/ and for 8/8 had to tweak the creation factor to 80% due to having added a large comment. Maybe something like the below makes more sense for format-patch? Also, the "Algorithm" section of git-range-diff describ