Re: [add-default-config 2/5] adding default to color

On Mon, Nov 13, 2017 at 12:40:16PM +0900, Junio C Hamano wrote: > As an aside. Over time we accumulated quite a many actions that are > all mutually exclusive by nature. I have a feeling that we might be > better off to move away from this implementation. The only thing > that we are getting

Re: [add-default-config 2/5] adding default to color

Jeff King writes: >> @@ -47,6 +48,7 @@ static int show_origin; >> #define ACTION_GET_COLOR (1<<13) >> #define ACTION_GET_COLORBOOL (1<<14) >> #define ACTION_GET_URLMATCH (1<<15) >> +#define ACTION_GET_COLORORDEFAULT (1<<16) > > I'm not sure I understand this part, though.

Re: [add-default-config 2/5] adding default to color

On Sun, Nov 12, 2017 at 03:00:40PM +, Soukaina NAIT HMID wrote: > diff --git a/builtin/config.c b/builtin/config.c > index 124a682d50fa8..9df2d9c43bcad 100644 > --- a/builtin/config.c > +++ b/builtin/config.c > @@ -30,6 +30,7 @@ static int end_null; > static int respect_includes_opt = -1; >

[add-default-config 2/5] adding default to color

From: Soukaina NAIT HMID Signed-off-by: Soukaina NAIT HMID --- builtin/config.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/builtin/config.c b/builtin/config.c index 124a682d50fa8..9df2d9c43bcad 100644 ---