Re: [bug] [UX] `stash save --untracked` produces a stash that *looks* empty

2014-10-08 Thread Tanay Abhra
On 10/5/2014 10:58 PM, Alberto Scotto wrote: Hi all, I've just found that: - given you have an empty staging area - and you have only untracked files in your working dir - when you do `git stash --untracked` - then `git stash show` gives you an empty output = stash looks empty My first

Re: [bug] [UX] `stash save --untracked` produces a stash that *looks* empty

2014-10-08 Thread Jeff King
On Wed, Oct 08, 2014 at 02:50:14PM +0530, Tanay Abhra wrote: I think problem lies with show_stash() which just shows the diff between working tree and the base tree, it ignores the untracked files. A quick and dirty fix can be to just show the diff between the untracked files and a NULL

[bug] [UX] `stash save --untracked` produces a stash that *looks* empty

2014-10-05 Thread Alberto Scotto
Hi all, I've just found that: - given you have an empty staging area - and you have only untracked files in your working dir - when you do `git stash --untracked` - then `git stash show` gives you an empty output = stash looks empty My first thought was oh god, my files are lost! Second thought: