Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Erik Faye-Lund
On Tue, Dec 4, 2012 at 6:12 PM, Johannes Schindelin wrote: > Hi kusma, > > On Sat, 1 Dec 2012, Erik Faye-Lund wrote: > >> On Fri, Nov 30, 2012 at 6:58 PM, Johannes Schindelin >> wrote: >> > Hi, >> > >> > On Tue, 13 Nov 2012, Erik Faye-Lund wrote: >> > >> >> Set a control-handler to prevent the pr

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Johannes Schindelin
Hi kusma, On Sat, 1 Dec 2012, Erik Faye-Lund wrote: > On Fri, Nov 30, 2012 at 6:58 PM, Johannes Schindelin > wrote: > > Hi, > > > > On Tue, 13 Nov 2012, Erik Faye-Lund wrote: > > > >> Set a control-handler to prevent the process from terminating, and > >> simulate SIGINT so it can be handled by

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-01 Thread Jeff King
On Sat, Dec 01, 2012 at 01:31:23PM +0100, Erik Faye-Lund wrote: > >> One thing you might want to mention is that the fgetc() handling is not > >> thread-safe, and intentionally so: if two threads read from the same > >> console, we are in trouble anyway. > > > > That makes sense to me, but I'm con

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-01 Thread Erik Faye-Lund
On Fri, Nov 30, 2012 at 6:58 PM, Johannes Schindelin wrote: > Hi, > > On Tue, 13 Nov 2012, Erik Faye-Lund wrote: > >> Set a control-handler to prevent the process from terminating, and >> simulate SIGINT so it can be handled by a signal-handler as usual. > > One thing you might want to mention is

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-01 Thread Erik Faye-Lund
On Fri, Nov 30, 2012 at 7:11 PM, Jeff King wrote: > On Fri, Nov 30, 2012 at 06:58:11PM +0100, Johannes Schindelin wrote: > >> Hi, >> >> On Tue, 13 Nov 2012, Erik Faye-Lund wrote: >> >> > Set a control-handler to prevent the process from terminating, and >> > simulate SIGINT so it can be handled by

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-11-30 Thread Jeff King
On Fri, Nov 30, 2012 at 06:58:11PM +0100, Johannes Schindelin wrote: > Hi, > > On Tue, 13 Nov 2012, Erik Faye-Lund wrote: > > > Set a control-handler to prevent the process from terminating, and > > simulate SIGINT so it can be handled by a signal-handler as usual. > > One thing you might want

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-11-30 Thread Johannes Schindelin
Hi, On Tue, 13 Nov 2012, Erik Faye-Lund wrote: > Set a control-handler to prevent the process from terminating, and > simulate SIGINT so it can be handled by a signal-handler as usual. One thing you might want to mention is that the fgetc() handling is not thread-safe, and intentionally so: if t