Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-29 Thread David Aguilar
On Tue, May 28, 2013 at 9:19 PM, Duy Nguyen pclo...@gmail.com wrote: On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen pclo...@gmail.com wrote: The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not blaming, just wanted to narrow down the problem). The patterns of interest seem to be

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-29 Thread Karsten Blees
Am 29.05.2013 06:19, schrieb Duy Nguyen: On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen pclo...@gmail.com wrote: The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not blaming, just wanted to narrow down the problem). The patterns of interest seem to be !/bin /bin/* !/bin/brew

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-29 Thread Øystein Walle
Karsten Blees karsten.blees at gmail.com writes: at Øystein: in the meantime, could you check if this fixes the problem for you? --- 8 --- diff --git a/dir.c b/dir.c index a5926fb..13858fe 100644 --- a/dir.c +++ b/dir.c at at -821,6 +821,9 at at static void prep_exclude(struct

1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-28 Thread Misty De Meo
Hi, Gitignore parsing no longer seems to work properly in git 1.8.3. One of my repositories has the following gitignore: /* !/.gitignore !/Library/ !/CONTRIBUTING.md !/README.md !/SUPPORTERS.md !/bin /bin/* !/bin/brew !/share/man/man1/brew.1 .DS_Store /Library/LinkedKegs /Library/PinnedKegs

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-28 Thread Øystein Walle
Misty De Meo misty at brew.sh writes: Hi, Gitignore parsing no longer seems to work properly in git 1.8.3. One of my repositories has the following gitignore: /* !/.gitignore !/Library/ !/CONTRIBUTING.md !/README.md !/SUPPORTERS.md !/bin /bin/* !/bin/brew !/share/man/man1

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-28 Thread Junio C Hamano
Øystein Walle oys...@gmail.com writes: Misty De Meo misty at brew.sh writes: Hi, Gitignore parsing no longer seems to work properly in git 1.8.3. One of my repositories has the following gitignore: /* !/.gitignore !/Library/ !/CONTRIBUTING.md !/README.md !/SUPPORTERS.md !/bin

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-28 Thread Duy Nguyen
On Wed, May 29, 2013 at 12:54 AM, Misty De Meo mi...@brew.sh wrote: Hi, Gitignore parsing no longer seems to work properly in git 1.8.3. One of my repositories has the following gitignore: /* !/.gitignore !/Library/ !/CONTRIBUTING.md !/README.md !/SUPPORTERS.md !/bin /bin/* !/bin

Re: 1.8.3 - gitignore not being parsed correctly on OS X; regex support is broken?

2013-05-28 Thread Duy Nguyen
On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen pclo...@gmail.com wrote: The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not blaming, just wanted to narrow down the problem). The patterns of interest seem to be !/bin /bin/* !/bin/brew Without !/bin v1.8.3 seems to behave the

Re: .gitignore behavior on Mac

2013-05-19 Thread Junio C Hamano
Peter Lauri peterla...@gmail.com writes: Great, I have gotten the concept now :) My workaround for my problem is to rename the file to default and then all will work out well :) Copy the file then and locally modify it, but it will be in .gitignore so not tracked :) I think

Re: .gitignore behavior on Mac

2013-05-19 Thread Antony Male
On 18/05/2013 23:37, Peter Lauri wrote: Great, I have gotten the concept now :) My workaround for my problem is to rename the file to default and then all will work out well :) Copy the file then and locally modify it, but it will be in .gitignore so not tracked :) Over in the #git IRC

.gitignore behavior on Mac

2013-05-18 Thread Peter Lauri
Shouldn't this be valid? I would expect to NOT see the core/inc/config.inc.php in the git status output... Peters-MacBook-Air:dt-git plauri$ cat .gitignore .buildpath .project .settings/ web/pjotr.php core/inc/config.inc.php dt_error.log process_wrapper.sh Peters-MacBook-Air:dt-git plauri$ git

Re: .gitignore behavior on Mac

2013-05-18 Thread John Keeping
On Sat, May 18, 2013 at 08:36:42PM +0200, Peter Lauri wrote: Shouldn't this be valid? I would expect to NOT see the core/inc/config.inc.php in the git status output... Peters-MacBook-Air:dt-git plauri$ cat .gitignore .buildpath .project .settings/ web/pjotr.php core/inc/config.inc.php

Re: .gitignore behavior on Mac

2013-05-18 Thread Peter Lauri
:42PM +0200, Peter Lauri wrote: Shouldn't this be valid? I would expect to NOT see the core/inc/config.inc.php in the git status output... Peters-MacBook-Air:dt-git plauri$ cat .gitignore .buildpath .project .settings/ web/pjotr.php core/inc/config.inc.php dt_error.log process_wrapper.sh

Re: .gitignore behavior on Mac

2013-05-18 Thread John Keeping
On Sat, May 18, 2013 at 08:43:57PM +0200, Peter Lauri wrote: But I just don't want to see that darn file. It is a config file that I have changed, and I don't want to need to stash it for each git svn action I want to perform... Any solution for that? Read about --assume-unchanged in

Re: .gitignore behavior on Mac

2013-05-18 Thread Johannes Sixt
Am 18.05.2013 20:55, schrieb John Keeping: On Sat, May 18, 2013 at 08:43:57PM +0200, Peter Lauri wrote: But I just don't want to see that darn file. It is a config file that I have changed, and I don't want to need to stash it for each git svn action I want to perform... Any solution for that?

Re: .gitignore behavior on Mac

2013-05-18 Thread Peter Lauri
Great, I have gotten the concept now :) My workaround for my problem is to rename the file to default and then all will work out well :) Copy the file then and locally modify it, but it will be in .gitignore so not tracked :) On Sat, May 18, 2013 at 11:01 PM, Johannes Sixt j...@kdbg.org

[PATCH 02/19] Add from-submodule. Conflicts: .gitignore contrib/subtree/git-subtree.sh test.sh

2013-03-09 Thread Paul Campbell
From 718c99d167255b28830b6f684d6e6e184fba0f7c Mon Sep 17 00:00:00 2001 From: Paul Campbell pcampb...@kemitix.net Date: Sat, 9 Mar 2013 18:30:20 + Subject: [PATCH 02/19] Add from-submodule. Conflicts: .gitignore contrib/subtree/git-subtree.sh test.sh Original-Author: Peter Jaros pja

Re: Ignore pattern with trailing whitespace in .gitignore is void using git 1.8.1.5

2013-03-08 Thread Junio C Hamano
Thor Andreas Rognan thor.rog...@gmail.com writes: Maybe I'm doing it wrong, or maybe it's the intended behaviour, but I find that a trailing whitespace after a pattern in .gitignore makes the pattern void with git 1.8.1.5. I doubt we do anything clever like that. $ git init

Re: Ignore pattern with trailing whitespace in .gitignore is void using git 1.8.1.5

2013-03-08 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Thor Andreas Rognan thor.rog...@gmail.com writes: Maybe I'm doing it wrong, or maybe it's the intended behaviour, but I find that a trailing whitespace after a pattern in .gitignore makes the pattern void with git 1.8.1.5. I doubt we do anything

Re: Configurable .gitignore filename?

2013-03-05 Thread David Aguilar
On Mon, Mar 4, 2013 at 7:47 AM, Jari Pennanen jari.penna...@gmail.com wrote: 2013/3/4 Matthieu Moy matthieu@grenoble-inp.fr: There is already core.excludesfile, which does not replace the usual .gitignore but comes in addition. The common use is a user-wide ignore file, not a per-directory

Re: Configurable .gitignore filename?

2013-03-05 Thread Jari Pennanen
2013/3/5 David Aguilar dav...@gmail.com: On Mon, Mar 4, 2013 at 7:47 AM, Jari Pennanen jari.penna...@gmail.com wrote: I'm actually aware of that. Problem is the normal .gitignore files must *not* be used in the second GIT_DIR at all, in my case it's for syncing so I need to sync almost all

Configurable .gitignore filename?

2013-03-04 Thread Jari Pennanen
If project or directory belongs to more than one GIT_DIR then some of the GIT_DIR's may need a different .gitignore files, it would be useful if one could define it independently, e.g. in GIT_DIR/config: [core] ignorefilename = .gitalternateignore Has anyone considered making the .gitignore

Re: Configurable .gitignore filename?

2013-03-04 Thread Matthieu Moy
Jari Pennanen jari.penna...@gmail.com writes: If project or directory belongs to more than one GIT_DIR then some of the GIT_DIR's may need a different .gitignore files, it would be useful if one could define it independently, e.g. in GIT_DIR/config: [core] ignorefilename

Re: Configurable .gitignore filename?

2013-03-04 Thread Jari Pennanen
2013/3/4 Matthieu Moy matthieu@grenoble-inp.fr: There is already core.excludesfile, which does not replace the usual .gitignore but comes in addition. The common use is a user-wide ignore file, not a per-directory one. I'm actually aware of that. Problem is the normal .gitignore files must

Re: [PATCH] gitk-git/.gitignore: add rule for gitk-wish

2013-02-01 Thread Jonathan Nieder
Hi Ram, Ramkumar Ramachandra wrote: 8f26aa4 (Makefile: remove tracking of TCLTK_PATH, 2012-12-18) removed /gitk-git/gitk-wish from the toplevel .gitignore, with the intent of moving it to gitk-git/.gitignore in a later patch. This was never realized. Signed-off-by: Ramkumar Ramachandra

Re: [PATCH] gitk-git/.gitignore: add rule for gitk-wish

2013-02-01 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Looks like this was fixed in the week since last pull. http://thread.gmane.org/gmane.comp.version-control.git/214312 Paul, would it be safe for Junio to pull again? Thanks. I think I pulled a few days ago, and the result should have already

[PATCH] gitk-git/.gitignore: add rule for gitk-wish

2013-01-29 Thread Ramkumar Ramachandra
8f26aa4 (Makefile: remove tracking of TCLTK_PATH, 2012-12-18) removed /gitk-git/gitk-wish from the toplevel .gitignore, with the intent of moving it to gitk-git/.gitignore in a later patch. This was never realized. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- Minor patch, so I

[PATCH] .gitignore: ignore generated gitk-git/gitk-wish

2013-01-24 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index aa258a6..63d4904 100644 --- a/.gitignore +++ b/.gitignore @@ -171,6 +171,7 @@ /git-whatchanged /git-write-tree /git-core-*/?* +/gitk-git/gitk

[PATCH 5/6] gitignore: make pattern parsing code a separate function

2012-10-15 Thread Nguyễn Thái Ngọc Duy
This function can later be reused by attr.c. Also turn to_exclude field into a flag. Signed-off-by: Junio C Hamano gits...@pobox.com Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- dir.c | 71 ++- dir.h | 2 +- 2 files

[PATCH 6/6] attr: more matching optimizations from .gitignore

2012-10-15 Thread Nguyễn Thái Ngọc Duy
.gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch reuses the core matching functions that are also used by excluded_from_list

[PATCH 13/13] Support ** wildcard in .gitignore and .gitattributes

2012-10-15 Thread Nguyễn Thái Ngọc Duy
, the same as pattern `foo`. **/foo/bar + matches file or directory `bar` anywhere that is directly + under directory `foo`. + + - A trailing /** matches everything inside. For example, + abc/** matches all files inside directory abc, relative + to the location of the `.gitignore` file

[PATCH 1/2] config, gitignore: failure to access with ENOTDIR is ok

2012-10-13 Thread Jonathan Nieder
The access_or_warn() function is used to check for optional configuration files like .gitconfig and .gitignore and warn when they are not accessible due to a configuration issue (e.g., bad permissions). It is not supposed to complain when a file is simply missing. Noticed on a system where

[PATCH v5 12/12] Support ** wildcard in .gitignore and .gitattributes

2012-10-13 Thread Nguyễn Thái Ngọc Duy
+ to the location of the `.gitignore` file, with infinite depth. + + - A slash followed by two consecutive asterisks then a slash + matches zero or more directories. For example, `a/**/b` + matches `a/b`, `a/x/b`, `a/x/y/b` and so on. + + - Other consecutive asterisks are considered invalid. + NOTES

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-12 Thread Nguyen Thai Ngoc Duy
On Thu, Oct 11, 2012 at 3:03 AM, Junio C Hamano gits...@pobox.com wrote: It would save time from both of us if you can check what is queued on 'pu'. I do not think I touched the code for off-by-one bugs there, though. 'pu' looks good. -- Duy -- To unsubscribe from this list: send the line

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-12 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 51f3045..4a1402f 100755 --- a/t/t0003-attributes.sh +++ b/t/t0003-attributes.sh @@ -242,4 +242,18 @@ test_expect_success 'bare repository: test info/attributes' '

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-12 Thread Nguyen Thai Ngoc Duy
On Fri, Oct 12, 2012 at 12:09:57PM -0700, Junio C Hamano wrote: This is not entirely your fault, but please don't do that cd ... The original test had cd bare, made an assumption that step will never fail (which is mostly correct), and ran everything afterward in that subdirectory. Adding

[PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-10 Thread Nguyễn Thái Ngọc Duy
.gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations to attr. Basically it tries to avoid fnmatch as much

[PATCH v4 11/12] Support ** wildcard in .gitignore and .gitattributes

2012-10-10 Thread Nguyễn Thái Ngọc Duy
/gitattributes.txt +++ b/Documentation/gitattributes.txt @@ -57,6 +57,12 @@ overrides an earlier line. This overriding is done per attribute. The rules how the pattern matches paths are the same as in `.gitignore` files; see linkgit:gitignore[5]. +Note that if a .gitignore rule matches a directory

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: .gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-10 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: @@ -690,16 +689,18 @@ static int path_matches(const char *pathname, int pathlen, * contain the trailing slash */ - if (pathlen baselen || + if (pathlen baselen + 1 ||

Re: [PATCH v2 2/2] attr: more matching optimizations from .gitignore

2012-10-10 Thread Nguyen Thai Ngoc Duy
On Thu, Oct 11, 2012 at 4:41 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: @@ -690,16 +689,18 @@ static int path_matches(const char *pathname, int pathlen, * contain the trailing slash */ - if (pathlen baselen || +

Re: [PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-09 Thread Johannes Sixt
Am 10/9/2012 7:08, schrieb Junio C Hamano: Imagine if we allowed only one attribute per line, instead of multiple attributes on one line. - If you want to unset the attribute, you would write path -attr. - If you want to reset the attribute to unspecified, you would write path

Re: [PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-09 Thread Junio C Hamano
Johannes Sixt j.s...@viscovery.net writes: Am 10/9/2012 7:08, schrieb Junio C Hamano: Imagine if we allowed only one attribute per line, instead of multiple attributes on one line. - If you want to unset the attribute, you would write path -attr. - If you want to reset the

Re: [PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Johannes Sixt j.s...@viscovery.net writes: Am 10/9/2012 7:08, schrieb Junio C Hamano: Imagine if we allowed only one attribute per line, instead of multiple attributes on one line. - If you want to unset the attribute, you would write path

Re: [PATCH 8/8] Support ** wildcard in .gitignore and .gitattributes

2012-10-09 Thread Nguyen Thai Ngoc Duy
. For example, /abc/** is equivalent to `/abc/`. or - A trailing /** matches everything inside. For example, abc/** is equivalent to `abc/` (which is also equivalent to `/abc/`). The tricky thing in .gitignore is that the last '/' alone does not imply anchor. So abc/ means match

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-08 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: My objection is no-op lines are timed bombs. But users can already do dir attr (no slashes), which is no-op. So yeah, no-op is fine. Exactly. If you are not catching and barfing the no-slashed variant at the syntax level (and you shouldn't), you

[PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-08 Thread Nguyễn Thái Ngọc Duy
.gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations to attr. Basically it tries to avoid fnmatch as much

[PATCH 8/8] Support ** wildcard in .gitignore and .gitattributes

2012-10-08 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- Documentation/gitignore.txt| 19 +++ attr.c | 4 +++- dir.c | 4 +++- t/t0003-attributes.sh | 38 ++

Re: [PATCH nd/attr-match-optim-more 2/2] attr: more matching optimizations from .gitignore

2012-10-08 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: .gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-07 Thread Nguyen Thai Ngoc Duy
On Sat, Oct 6, 2012 at 1:48 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: +Unlike `.gitignore`, negative patterns are not supported. +Patterns that match directories are also not supported. Is are not supported the right phrasing? I think

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-06 Thread Nguyen Thai Ngoc Duy
On Sat, Oct 6, 2012 at 12:36 PM, Junio C Hamano gits...@pobox.com wrote: Or the user might think path/ attr1 sets attr1 for all files under path/ because it does not make sense to attach attributes to a directory in git. ... We may not have a need to assign a real attribute to a

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-06 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: On Sat, Oct 6, 2012 at 12:36 PM, Junio C Hamano gits...@pobox.com wrote: Or the user might think path/ attr1 sets attr1 for all files under path/ because it does not make sense to attach attributes to a directory in git. ... We may not

Re: [PATCH 5/6] gitignore: do not do basename match with patterns that have '**'

2012-10-05 Thread Johannes Sixt
Am 10/4/2012 9:39, schrieb Nguyễn Thái Ngọc Duy: - - If the pattern does not contain a slash '/', git treats it as - a shell glob pattern and checks for a match against the - pathname relative to the location of the `.gitignore` file - (relative to the toplevel of the work tree

[PATCH 10/10] gitignore: forbid abc**def

2012-10-05 Thread Nguyễn Thái Ngọc Duy
[i + 2] == '\\' p[i + 3] == '/' + die(_(** in .gitignore or .gitattributes must be wrapped by slashes)); } - if (i == len) - *flags |= EXC_FLAG_NODIR; *nowildcardlen = simple_length(p); /* * we should have excluded

[PATCH 01/10] gitignore: make pattern parsing code a separate function

2012-10-05 Thread Nguyễn Thái Ngọc Duy
This function can later be reused by attr.c. Also turn to_exclude field into a flag. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- If we go with glob-regex conversion way, this is where we could rewrite the pattern (and set EXC_FLAG_REGEX). dir.c | 71

[PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-05 Thread Nguyễn Thái Ngọc Duy
.gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations to .gitattributes. Basically it tries to avoid fnmatch

Re: [PATCH 5/6] gitignore: do not do basename match with patterns that have '**'

2012-10-05 Thread Nguyen Thai Ngoc Duy
of the `.gitignore` file - (relative to the toplevel of the work tree if not from a - `.gitignore` file). + - If the pattern does not contain a slash '/' nor '**', git + treats it as a shell glob pattern and checks for a match + against the pathname relative to the location

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-05 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: +Unlike `.gitignore`, negative patterns are not supported. +Patterns that match directories are also not supported. Is are not supported the right phrasing? I think it makes perfect sense not to forbid !path attr1, because it is unclear what

Re: [PATCH 04/10] attr: more matching optimizations from .gitignore

2012-10-05 Thread Nguyen Thai Ngoc Duy
On Sat, Oct 6, 2012 at 1:48 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: +Unlike `.gitignore`, negative patterns are not supported. +Patterns that match directories are also not supported. Is are not supported the right phrasing? I think

[PATCH 4/6] attr: more matching optimizations from .gitignore

2012-10-04 Thread Nguyễn Thái Ngọc Duy
.gitattributes and .gitignore share the same pattern syntax but has separate matching implementation. Over the years, ignore's implementation accumulates more optimizations while attr's stays the same. This patch adds those optimizations to .gitattributes. Basically it tries to avoid fnmatch

[PATCH 5/6] gitignore: do not do basename match with patterns that have '**'

2012-10-04 Thread Nguyễn Thái Ngọc Duy
works in general in git). - - If the pattern does not contain a slash '/', git treats it as - a shell glob pattern and checks for a match against the - pathname relative to the location of the `.gitignore` file - (relative to the toplevel of the work tree if not from a - `.gitignore` file

Re: [PATCH 5/6] gitignore: do not do basename match with patterns that have '**'

2012-10-04 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: - if (!strchr(p, '/')) + if (!strchr(p, '/') !strstr(p, **)) Doesn't wildmatch allow these to be quoted, similar to the way usual glob works, e.g. $ ff $ \?f $ echo ?? ?f ff $ echo

Re: [ENHANCEMENT] Allow '**' pattern in .gitignore

2012-10-03 Thread Nguyen Thai Ngoc Duy
if you only have a toplevel .gitignore, as opposed to a per-directory .gitignore. Unfortunately, .gitignore currently uses fnmatch(3), and doesn't recognize '**'. Would extending the .gitignore format to accept this be a useful feature? Would it involve re-implementing and extending fnmatch

Re: [ENHANCEMENT] Allow '**' pattern in .gitignore

2012-10-03 Thread Jens Lehmann
crossing directory boundaries: it's especially useful if you only have a toplevel .gitignore, as opposed to a per-directory .gitignore. Unfortunately, .gitignore currently uses fnmatch(3), and doesn't recognize '**'. Would extending the .gitignore format to accept this be a useful feature

Re: [ENHANCEMENT] Allow '**' pattern in .gitignore

2012-10-03 Thread Nguyen Thai Ngoc Duy
On Wed, Oct 3, 2012 at 8:35 PM, Jens Lehmann jens.lehm...@web.de wrote: */foo/bar */*/foo/bar */*/*/foo/bar Using **/foo/bar instead would be a great improvement If this **/foo/bar (i.e. no wildcards except one ** at the beginning) is popular, we could optimize this case, turning fmatch()

Re: [ENHANCEMENT] Allow '**' pattern in .gitignore

2012-10-02 Thread Stefano Lattarini
On 10/02/2012 09:21 AM, Ramkumar Ramachandra wrote: Hi, I've often found the '**' (extended) shell glob useful for matching any string crossing directory boundaries: it's especially useful if you only have a toplevel .gitignore, as opposed to a per-directory .gitignore. Unfortunately

Re: [ENHANCEMENT] Allow '**' pattern in .gitignore

2012-10-02 Thread Ramkumar Ramachandra
Stefano Lattarini wrote: On 10/02/2012 09:21 AM, Ramkumar Ramachandra wrote: Hi, I've often found the '**' (extended) shell glob useful for matching any string crossing directory boundaries: it's especially useful if you only have a toplevel .gitignore, as opposed to a per-directory

[PATCH 5/5] Support ** in .gitignore and .gitattributes patterns using wildmatch()

2012-09-26 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com Signed-off-by: Junio C Hamano gits...@pobox.com --- Documentation/gitignore.txt| 3 +++ attr.c | 4 +++- dir.c | 5 - t/t0003-attributes.sh | 17

Re: /* in .gitignore

2012-09-25 Thread Junio C Hamano
Hilco Wijbenga hilco.wijbe...@gmail.com writes: Naturally, this behaviour makes perfect sense: /* means everything. Still, I was wondering whether it might be a good idea to make an exception for '.gitignore' itself? Then if somebody *really* wanted to ignore '.gitignore' they could add

Re: /* in .gitignore

2012-09-25 Thread Hilco Wijbenga
On 25 September 2012 16:13, Junio C Hamano gits...@pobox.com wrote: Hilco Wijbenga hilco.wijbe...@gmail.com writes: Naturally, this behaviour makes perfect sense: /* means everything. Still, I was wondering whether it might be a good idea to make an exception for '.gitignore' itself

Re: [PATCH] t/perf: add trash directory to .gitignore

2012-09-18 Thread Ramkumar Ramachandra
Hi, Junio C Hamano wrote: Thanks. I _think_ you still want to make sure these are directories, so instead of losing the trailing slash, you would want to keep it and add a leading slash to anchor them to the t/perf directory, i.e. /build/ /test-results/ /trash

[PATCHv2 6/8] Doc add: link gitignore

2012-09-18 Thread Philip Oakley
Use a gitignore link rather than the gitrepository- layout link. Signed-off-by: Philip Oakley philipoak...@iee.org diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt index 9c1d395..fd9e36b 100644 --- a/Documentation/git-add.txt +++ b/Documentation/git-add.txt @@ -155,7 +155,7

[PATCHv2 5/8] Doc: separate gitignore pattern sources

2012-09-18 Thread Philip Oakley
Use separate bulleted paragraphs for the three different gitignore pattern sources. Signed-off-by: Philip Oakley philipoak...@iee.org diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt index c1f692a..96639e0 100644 --- a/Documentation/gitignore.txt +++ b/Documentation

Re: [PATCHv2 5/8] Doc: separate gitignore pattern sources

2012-09-18 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: Use separate bulleted paragraphs for the three different gitignore pattern sources. Signed-off-by: Philip Oakley philipoak...@iee.org Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCHv2 6/8] Doc add: link gitignore

2012-09-18 Thread Junio C Hamano
Philip Oakley philipoak...@iee.org writes: Use a gitignore link rather than the gitrepository- layout link. Signed-off-by: Philip Oakley philipoak...@iee.org Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] t/perf: add trash directory to .gitignore

2012-09-17 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- t/perf/.gitignore |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/t/perf/.gitignore b/t/perf/.gitignore index 50f5cc1..0061cbc 100644 --- a/t/perf

[PATCH 5/8] Doc: separate gitignore pattern sources

2012-09-16 Thread Philip Oakley
Use separate bulleted paragraphs for the three different gitignore pattern sources. Signed-off-by: Philip Oakley philipoak...@iee.org diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt index c1f692a..1a585e7 100644 --- a/Documentation/gitignore.txt +++ b/Documentation

[PATCH 6/8] Doc add: link gitignore

2012-09-16 Thread Philip Oakley
Include the gitignore link with the paired gitrepository- layout link. Signed-off-by: Philip Oakley philipoak...@iee.org --- without the gitignore link users are unlikely to realise the significance of the repository layout link, nor what to look for within it diff --git a/Documentation/git

[PATCH v2 0/5] Support matching ** in .gitattributes and .gitignore

2012-09-16 Thread Nguyễn Thái Ngọc Duy
Duy (5): Import wildmatch from rsync compat/wildmatch: remove static variable force_lower_case compat/wildmatch: fix case-insensitive matching Integrate wildmatch to git Support ** in .gitignore and .gitattributes patterns using wildmatch() .gitignore | 1

[PATCH 0/5] Support matching ** in .gitattributes and .gitignore

2012-09-15 Thread Nguyễn Thái Ngọc Duy
** in .gitignore and .gitattributes patterns using wildmatch() Documentation/gitignore.txt| 3 + Makefile | 6 + attr.c | 4 +- compat/wildmatch.c | 373 + compat/wildmatch.h | 6

[PATCH 5/5] Support ** in .gitignore and .gitattributes patterns using wildmatch()

2012-09-15 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- Documentation/gitignore.txt | 3 +++ attr.c | 4 +++- dir.c | 5 - 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt

Update arch/x86/boot/.gitignore with new auto-generated files

2008-02-10 Thread Linux Kernel Mailing List
: Sun Feb 10 05:18:08 2008 +0200 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Sat Feb 9 23:27:01 2008 -0800 Update arch/x86/boot/.gitignore with new auto-generated files Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED] Signed-off-by: Linus Torvalds [EMAIL PROTECTED] --- arch

Update kernel/.gitignore with new auto-generated files

2008-02-10 Thread Linux Kernel Mailing List
: Sun Feb 10 05:19:03 2008 +0200 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Sat Feb 9 23:27:01 2008 -0800 Update kernel/.gitignore with new auto-generated files Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED] Signed-off-by: Linus Torvalds [EMAIL PROTECTED] --- kernel

Add binoffset to gitignore

2008-02-09 Thread Linux Kernel Mailing List
: Tue Feb 5 11:44:52 2008 +0100 Committer: Sam Ravnborg [EMAIL PROTECTED] CommitDate: Sat Feb 9 10:43:58 2008 +0100 Add binoffset to gitignore Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] --- scripts/.gitignore |1 + 1 files

[POWERPC] Update .gitignore files

2008-01-30 Thread Linux Kernel Mailing List
: Tue Jan 1 03:14:53 2008 +1100 Committer: Paul Mackerras [EMAIL PROTECTED] CommitDate: Thu Jan 17 14:57:09 2008 +1100 [POWERPC] Update .gitignore files Update .gitignore as needed by dtc addition. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: David Gibson

x86: gitignore arch/x86/vdso files

2008-01-30 Thread Linux Kernel Mailing List
Jan 30 13:32:32 2008 +0100 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Wed Jan 30 13:32:32 2008 +0100 x86: gitignore arch/x86/vdso files Teach git to ignore generated files in arch/x86/vdso/* Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Cc: Roland McGrath

x86: add vdso32-int80-syms.lds to .gitignore

2008-01-30 Thread Linux Kernel Mailing List
: Wed Jan 30 13:33:24 2008 +0100 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Wed Jan 30 13:33:24 2008 +0100 x86: add vdso32-int80-syms.lds to .gitignore One of the generated files was missed in gitignore. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] Signed-off

x86: update .gitignore entries

2007-10-19 Thread Linux Kernel Mailing List
: Fri Oct 19 20:35:02 2007 +0200 Committer: Thomas Gleixner [EMAIL PROTECTED] CommitDate: Fri Oct 19 20:35:02 2007 +0200 x86: update .gitignore entries vdso / vsycall create .so.dbg files now. Add *.so.dbg to the main .ignore file Exclude the compile time created boot

.gitignore update for x86 arch

2007-10-17 Thread Linux Kernel Mailing List
: Tue Oct 16 11:22:21 2007 +0400 Committer: Thomas Gleixner [EMAIL PROTECTED] CommitDate: Wed Oct 17 21:19:04 2007 +0200 .gitignore update for x86 arch This patch: - makes .gitignore files visible to git - makes arch/x86/kernel/vsyscall_32.lds and arch/i386/boot invisible

dontdiff: update based on gitignore updates

2007-10-17 Thread Linux Kernel Mailing List
Oct 16 23:30:30 2007 -0700 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Wed Oct 17 08:43:01 2007 -0700 dontdiff: update based on gitignore updates Update dontdiff, based on .gitignore patches from Pete Zaitcev and Adrian Bunk. Signed-off-by: Randy Dunlap

[POWERPC] Update .gitignore for new vdso generated files

2007-10-11 Thread Linux Kernel Mailing List
Oct 3 10:43:10 2007 -0500 Committer: Kumar Gala [EMAIL PROTECTED] CommitDate: Mon Oct 8 08:38:12 2007 -0500 [POWERPC] Update .gitignore for new vdso generated files We now generate vdso[32,64].so.dbg as part of the build so add them to .gitignore Signed-off-by: Kumar Gala

[POWERPC] bootwrapper: Update .gitignore

2007-10-11 Thread Linux Kernel Mailing List
Aug 21 03:39:20 2007 +1000 Committer: Paul Mackerras [EMAIL PROTECTED] CommitDate: Wed Aug 22 15:21:47 2007 +1000 [POWERPC] bootwrapper: Update .gitignore All cuImage types are ignored, as well as preprocessed .lds files, and the forthcoming zImage.bin files and embedded planet

x86_64: vdso.lds in arch/x86_64/vdso/.gitignore

2007-08-11 Thread Linux Kernel Mailing List
Aug 10 22:31:09 2007 +0200 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Sat Aug 11 15:58:14 2007 -0700 x86_64: vdso.lds in arch/x86_64/vdso/.gitignore Create arch/x86_64/vdso/.gitignore and put vdso.lds into it. Signed-off-by: Pete Zaitcev [EMAIL PROTECTED

.gitignore update

2007-07-31 Thread Linux Kernel Mailing List
: Tue Jul 31 00:37:25 2007 -0700 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Tue Jul 31 15:39:36 2007 -0700 .gitignore update Somehow I ended up with the following in tree: $ git status ... # Untracked files: # (use git add file

Un-ignore vmlinux.lds.S in .gitignore

2007-07-20 Thread Linux Kernel Mailing List
: Fri Jul 20 14:53:52 2007 -0700 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Fri Jul 20 14:53:52 2007 -0700 Un-ignore vmlinux.lds.S in .gitignore We ignore all the generated files called vmlinux* from the top-level gitignore, but that also ends up catching a few files

Update .gitignore for arch/i386/boot

2007-07-19 Thread Linux Kernel Mailing List
: Thu Jul 19 13:09:10 2007 -0600 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Thu Jul 19 14:32:38 2007 -0700 Update .gitignore for arch/i386/boot With the new setup code, we generate a couple more files Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] [ .. and do

.gitignore update

2007-07-16 Thread Linux Kernel Mailing List
: Sun Jul 15 23:41:52 2007 -0700 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Mon Jul 16 09:05:52 2007 -0700 .gitignore update headers_install by default puts headers into usr/include/ . They're auto-generated, so should be ignored. Same for *.orig, *.rej

[ARM] 4449/1: more entries in arch/arm/boot/.gitignore

2007-06-26 Thread Linux Kernel Mailing List
: Wed Jun 20 19:10:34 2007 +0100 Committer: Russell King [EMAIL PROTECTED] CommitDate: Mon Jun 25 20:37:35 2007 +0100 [ARM] 4449/1: more entries in arch/arm/boot/.gitignore Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] Signed-off-by: Russell King [EMAIL PROTECTED] --- arch/arm/boot

[ARM] 4216/1: add .gitignore entries for ARM specific files

2007-02-19 Thread Linux Kernel Mailing List
: Sat Feb 17 03:37:02 2007 +0100 Committer: Russell King [EMAIL PROTECTED] CommitDate: Sat Feb 17 11:26:41 2007 + [ARM] 4216/1: add .gitignore entries for ARM specific files Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] Signed-off-by: Russell King [EMAIL PROTECTED] --- arch/arm

[PATCH] Add .gitignore file for relocs in arch/i386

2006-12-30 Thread Linux Kernel Mailing List
Dec 29 16:47:25 2006 -0800 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Sat Dec 30 10:55:55 2006 -0800 [PATCH] Add .gitignore file for relocs in arch/i386 Due to the changes to make the kernel relocateable a new file is created during the build process. [EMAIL

<    1   2   3   4   5   >