--trust-exit-code not working

2014-11-08 Thread Adri Farr
Hello!, Firstly, thank you very much to those that contributed the patch; I truly appreciate it. I haven't been able to make it work in 2.2.0.rc1, though. I'm not sure whether it's my fault, or the patch', but a 'git difftool --trust-exit-code' call with vimdiff as the diff tool and exiting with :

--trust-exit-code not working

2014-11-14 Thread Adria Farres
Hello!, I sent an email last week, but I'm not sure if I sent it incorrectly, or the formatting was very bad, or it went unnoticed. A few days ago a great soul was kind enough to create the --trust-exit-code option that made git respect the exit code of the difftool. Unfortunately, I haven't been

Re: --trust-exit-code not working

2014-11-14 Thread Junio C Hamano
David, I think this is about your 2b52123f (difftool: add support for --trust-exit-code, 2014-10-26). If you have time can you help Adria? Thanks. Adria Farres <14farr...@gmail.com> writes: > Hello!, > > I sent an email last week, but I'm not sure if I sent it incorrectly, or the > formatting

Re: --trust-exit-code not working

2014-11-14 Thread David Aguilar
On Fri, Nov 14, 2014 at 12:41:16PM -0800, Junio C Hamano wrote: > David, I think this is about your 2b52123f (difftool: add support > for --trust-exit-code, 2014-10-26). If you have time can you help > Adria? > > Thanks. Yup, I'll take a look when I have a chance. My first guess would be that t

Re: --trust-exit-code not working

2014-11-14 Thread David Aguilar
On Fri, Nov 14, 2014 at 05:12:35PM +0100, Adria Farres wrote: > Hello!, > > I sent an email last week, but I'm not sure if I sent it incorrectly, or the > formatting was very bad, or it went unnoticed. A few days ago a great soul was Nah, I was just very busy and it slipped through the cracks. So