Re: .gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-16 Thread Duy Nguyen
On Mon, Apr 16, 2018 at 12:40 AM, Andreas Schwab wrote: > On Apr 16 2018, Junio C Hamano wrote: > >> I may be mistaken (I do not have the code in front of me right now) >> but IIRC after the setup.c code runs (which happens quite early in >> the sequence

Re: .gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-15 Thread Andreas Schwab
On Apr 16 2018, Junio C Hamano wrote: > I may be mistaken (I do not have the code in front of me right now) > but IIRC after the setup.c code runs (which happens quite early in > the sequence that starts from git.c::cmd_main()), the Git process > moves to the top level of the

Re: .gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-15 Thread Junio C Hamano
Andreas Schwab writes: > The functions in attr.c do not look at $GIT_WORK_TREE when trying to > find the .gitattributes file. Thus if you are not inside the work tree, > but have GIT_WORK_TREE set attribute lookup will be wrong. I may be mistaken (I do not have the code

.gitattributes lookup doesn't respect GIT_WORK_TREE

2018-04-15 Thread Andreas Schwab
The functions in attr.c do not look at $GIT_WORK_TREE when trying to find the .gitattributes file. Thus if you are not inside the work tree, but have GIT_WORK_TREE set attribute lookup will be wrong. Password Store is using this feature when the password store is