Re: 2.19.0 regression: leaving editor with empty commit message doesn't stop rebase [was: Re: [RFC PATCH v5 9/9] git-rebase: make --allow-empty-message the default]

Hi, On Tue, Sep 11, 2018 at 7:42 PM SZEDER Gábor wrote: > Lately I noticed that occasionally I ended up with an empty commit > message after an interactive rebase...those empty commit messages are the > consequence of a regression in v2.19.0, which bisects down to this > patch. > > To reproduce

2.19.0 regression: leaving editor with empty commit message doesn't stop rebase [was: Re: [RFC PATCH v5 9/9] git-rebase: make --allow-empty-message the default]

Lately I noticed that occasionally I ended up with an empty commit message after an interactive rebase. However, since I didn't do anything that I haven't already done countless times before, I thought that one of my local patches touching the area where 'git commit' calls launch_editor() got