Re: About close() in commit_lock_file()

2013-08-06 Thread Johannes Sixt
Am 8/5/2013 16:23, schrieb Duy Nguyen: close() is added in commit_lock_file(), before rename(), by 4723ee9 (Close files opened by lock_file() before unlinking. - 2007-11-13), which is needed by Windows. But doesn't that create a gap between close() and rename() on other platforms where another

Re: About close() in commit_lock_file()

2013-08-06 Thread Duy Nguyen
On Tue, Aug 6, 2013 at 1:41 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 8/5/2013 16:23, schrieb Duy Nguyen: close() is added in commit_lock_file(), before rename(), by 4723ee9 (Close files opened by lock_file() before unlinking. - 2007-11-13), which is needed by Windows. But doesn't that

About close() in commit_lock_file()

2013-08-05 Thread Duy Nguyen
close() is added in commit_lock_file(), before rename(), by 4723ee9 (Close files opened by lock_file() before unlinking. - 2007-11-13), which is needed by Windows. But doesn't that create a gap between close() and rename() on other platforms where another process can replace .lock file with

Re: About close() in commit_lock_file()

2013-08-05 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: close() is added in commit_lock_file(), before rename(), by 4723ee9 (Close files opened by lock_file() before unlinking. - 2007-11-13), which is needed by Windows. But doesn't that create a gap between close() and rename() on other platforms where another