Re: Bug: pager. doesn't work well with editors

2016-09-22 Thread Jeff King
On Thu, Sep 22, 2016 at 10:19:32AM -0700, Junio C Hamano wrote: > The level at which configurability happens might be one issue > (i.e. you may want different pager for two operating modes for the > same command, hence your need to use "tag.list" not just "tag"), but > I think another issue is

Re: Bug: pager. doesn't work well with editors

2016-09-22 Thread Junio C Hamano
Jeff King writes: > I don't think it is a bad move overall. I use "pager.log" to pipe > through a specific command (that is different than I would use for other > commands). > > So I like the idea of configurability; the problem is just that it is > happening at the wrong level.

Re: Bug: pager. doesn't work well with editors

2016-09-22 Thread Jeff King
On Wed, Sep 21, 2016 at 09:15:09AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > And this isn't really limited to the editor. It's more _annoying_ with > > the editor, but really "pager.tag" does not make any sense to set right > > now, because it is handled outside of

Re: Bug: pager. doesn't work well with editors

2016-09-21 Thread Junio C Hamano
Jeff King writes: > And this isn't really limited to the editor. It's more _annoying_ with > the editor, but really "pager.tag" does not make any sense to set right > now, because it is handled outside of the "tag" command entirely, and > doesn't know what mode the tag command

Re: Bug: pager. doesn't work well with editors

2016-09-19 Thread Jeff King
On Mon, Sep 19, 2016 at 09:03:05AM -0700, Junio C Hamano wrote: > Anatoly Borodin writes: > > >> I think, the pagination should be turned off when the editor is being > >> called. > > This is a fun one. IIRC, we decide to spawn a pager and run our > output via pipe

Re: Bug: pager. doesn't work well with editors

2016-09-19 Thread Junio C Hamano
Anatoly Borodin writes: >> I think, the pagination should be turned off when the editor is being >> called. This is a fun one. IIRC, we decide to spawn a pager and run our output via pipe thru it fairly early, even before we figure out which subcommand is being run

Re: Bug: pager. doesn't work well with editors

2016-09-18 Thread Anatoly Borodin
> I think, the pagination should be turned off when the editor is being > called. ... even if the `[-p|--paginate]` option is used explicitly. Is there a case when pagination shouldn't be ignored with an editor? `git -p -c core.editor=gvim config -e` works, but the pagination is not effective.

Bug: pager. doesn't work well with editors

2016-09-18 Thread Anatoly Borodin
Hi All! It can be useful to enable `pager.branch`, `pager.tag`, `pager.config`, etc for some projects (`git` itself can be a good example, with all its feature branches and tags). But it makes commands like `git branch --edit-description`, `git tag -a`, `git config -e` extremely unhappy. For