Re: bug: git submodule add fails when .git is a symlink

2016-04-20 Thread Stefan Beller
On Wed, Apr 20, 2016 at 9:41 AM, Stefan Beller wrote: > On Wed, Mar 2, 2016 at 12:49 AM, Jeff King wrote: >> On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: >> >>> Junio C Hamano wrote: >>> > A more pertinent question may be which version of Git did

Re: bug: git submodule add fails when .git is a symlink

2016-04-20 Thread Stefan Beller
On Wed, Mar 2, 2016 at 12:49 AM, Jeff King wrote: > On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: > >> Junio C Hamano wrote: >> > A more pertinent question may be which version of Git did the above >> > ever work, I guess. We fairly liberally chdir around and I do not

Re: bug: git submodule add in of nested submodule handles relative path wrong

2016-03-02 Thread Stefan Beller
I'll add Jens, who has deep knowledge of submodules. On Wed, Mar 2, 2016 at 8:52 AM, Joey Hess wrote: > joey@darkstar:/tmp/empty>git init sub1 > Initialized empty Git repository in /tmp/empty/sub1/.git/ > joey@darkstar:/tmp/empty>git init sub2 > Initialized empty Git repository

bug: git submodule add in of nested submodule handles relative path wrong

2016-03-02 Thread Joey Hess
joey@darkstar:/tmp/empty>git init sub1 Initialized empty Git repository in /tmp/empty/sub1/.git/ joey@darkstar:/tmp/empty>git init sub2 Initialized empty Git repository in /tmp/empty/sub2/.git/ joey@darkstar:/tmp/empty>cd sub1 joey@darkstar:/tmp/empty/sub1>date > f1 ; git add f1; git commit -m add

Re: bug: git submodule add fails when .git is a symlink

2016-03-02 Thread Jeff King
On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote: > Junio C Hamano wrote: > > A more pertinent question may be which version of Git did the above > > ever work, I guess. We fairly liberally chdir around and I do not > > think we deliberately avoid assuming that "cd .git && cd .." might

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
Junio C Hamano wrote: > A more pertinent question may be which version of Git did the above > ever work, I guess. We fairly liberally chdir around and I do not > think we deliberately avoid assuming that "cd .git && cd .." might > not come back to the original directory, for example, so I

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
Stefan Beller wrote: > To elaborate on that: Starting in 2.7 parts of the submodule stuff > has been rewritten in C, in 2.8 even more and there is more in flight for > > 2.8. > > However your bug is also to be found in 2.6, which doesn't contain any > recent rewrites, so it is a rather long

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: >> git init gitdir >> mkdir worktree >> cd worktree >> ln -s ../gitdir/.git .git >> git submodule add /any/git/repo sub >> >> fatal:

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Stefan Beller
On Tue, Mar 1, 2016 at 1:39 PM, Stefan Beller wrote: > On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: >> git init gitdir >> mkdir worktree >> cd worktree >> ln -s ../gitdir/.git .git >> git submodule add

Re: bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Stefan Beller
On Tue, Mar 1, 2016 at 12:42 PM, Joey Hess wrote: > git init gitdir > mkdir worktree > cd worktree > ln -s ../gitdir/.git .git > git submodule add /any/git/repo sub > > fatal: Could not chdir to '../../../sub': No such file or

bug: git submodule add fails when .git is a symlink

2016-03-01 Thread Joey Hess
git init gitdir mkdir worktree cd worktree ln -s ../gitdir/.git .git git submodule add /any/git/repo sub fatal: Could not chdir to '../../../sub': No such file or directory Fairly sure this is a bug.. -- see shy jo signature.asc Description:

Re: Bug? git submodule add SSL certificate problem: unable to get local issuer certificate

2015-03-21 Thread Jeff King
On Tue, Mar 10, 2015 at 09:56:42PM +1300, Jens Lehmann wrote: Config like this is in a funny boat. We do not want it to cross transport boundaries, so that if we run: git -c foo=bar clone /some/local/path the process serving /some/local/path should not see the foo option[1]. But for

Re: Bug? git submodule add SSL certificate problem: unable to get local issuer certificate

2015-03-10 Thread Jens Lehmann
Am 09.03.2015 um 20:43 schrieb Jeff King: On Thu, Mar 05, 2015 at 04:20:10PM +0100, Aschemann Gerd wrote: seems to be a bug: If adding a submodule from an https URL with a certificate issued by StartSSL (or even a private/self-signed one?) leads to the following error: $ git -c

Re: Bug? git submodule add SSL certificate problem: unable to get local issuer certificate

2015-03-09 Thread Jeff King
On Thu, Mar 05, 2015 at 04:20:10PM +0100, Aschemann Gerd wrote: seems to be a bug: If adding a submodule from an https URL with a certificate issued by StartSSL (or even a private/self-signed one?) leads to the following error: $ git -c http.sslverify=false submodule add

Bug? git submodule add SSL certificate problem: unable to get local issuer certificate

2015-03-05 Thread Aschemann Gerd
Hi, seems to be a bug: If adding a submodule from an https URL with a certificate issued by StartSSL (or even a private/self-signed one?) leads to the following error: $ git -c http.sslverify=false submodule add https://example.com/git/xxx.git Cloning into 'xxx'... fatal: unable to

Re: Bug in Submodule add

2012-09-26 Thread Jens Lehmann
Am 26.09.2012 06:18, schrieb Jonathan Johnson: I believe I have found an issue with the way `submodule add` detects a submodule that already exists in the repository. Yes, this is an issue and thanks for the detailed report. To reproduce 1) add a git submodule in a specific location

Bug in Submodule add

2012-09-25 Thread Jonathan Johnson
I believe I have found an issue with the way `submodule add` detects a submodule that already exists in the repository. To reproduce 1) add a git submodule in a specific location (we'll say it's at `./submodule/location`) 2) go through the normal steps of removing a submodule, as listed here