Re: Bug in default commit hook (improperly forbidding a single blank line at EOF)

2015-09-07 Thread Jeff King
On Mon, Sep 07, 2015 at 06:37:29PM -0700, Raymond Jennings wrote: > Please see https://bugs.gentoo.org/show_bug.cgi?id=559920 for further > details. > > Files *should* have a single blank line at the end, because a line should > always have a newline at the end. I'm not sure I follow. Lines

Bug in default commit hook (improperly forbidding a single blank line at EOF)

2015-09-07 Thread Raymond Jennings
Please see https://bugs.gentoo.org/show_bug.cgi?id=559920 for further details. Files *should* have a single blank line at the end, because a line should always have a newline at the end. Adding a newline to the end of a file whose last line doesn't have one should be legal...as long as you

Re: Bug in default commit hook (improperly forbidding a single blank line at EOF)

2015-09-07 Thread Raymond Jennings
On 09/07/15 21:55, Jeff King wrote: On Mon, Sep 07, 2015 at 06:37:29PM -0700, Raymond Jennings wrote: Please see https://bugs.gentoo.org/show_bug.cgi?id=559920 for further details. Files *should* have a single blank line at the end, because a line should always have a newline at the end. I'm