Re: Bug report : bad filter-branch (OSX only)

2015-04-29 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, Apr 28, 2015 at 10:39:44PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: I'm not sure of a solution short of replacing the use of sed here with something else. perl would be a simple choice, but filter-branch does not otherwise

Re: Bug report : bad filter-branch (OSX only)

2015-04-29 Thread Jeff King
On Wed, Apr 29, 2015 at 09:30:00AM -0700, Junio C Hamano wrote: ( while read x test -n $x do :; done cat ) ../commit | eval $filter_msg would not spin too much in shell loop, perhaps? Yeah, that is not too bad. Probably we want read -r, just in

Re: Bug report : bad filter-branch (OSX only)

2015-04-28 Thread Olivier ROLAND
2015-04-28 7:55 GMT+02:00 Jeff King p...@peff.net: On Sun, Apr 26, 2015 at 11:25:52AM +0200, Olivier ROLAND wrote: OSX 10.10.3 git 2.3.6 HFS+ case-sensitive How to reproduce : Step 1 : git clone https://github.com/begeric/FastParsers.git Step 2 : cd FastParsers/ Step 3 : git filter-branch

Re: Bug report : bad filter-branch (OSX only)

2015-04-28 Thread Jeff King
On Wed, Apr 29, 2015 at 12:39:47AM -0400, Jeff King wrote: So I can't figure out how to replicate the problem here. Actually, that's not quite true. I could get hold of an OS X system to replicate, which I just did. The problem is that commit 3b754f212 does not have a newline at the end of its

Re: Bug report : bad filter-branch (OSX only)

2015-04-28 Thread Junio C Hamano
Jeff King p...@peff.net writes: I'm not sure of a solution short of replacing the use of sed here with something else. perl would be a simple choice, but filter-branch does not otherwise depend on it. We could use a shell read loop, but those are quite slow (and filter-branch is slow enough

Re: Bug report : bad filter-branch (OSX only)

2015-04-28 Thread Jeff King
On Tue, Apr 28, 2015 at 01:02:17PM +0200, Olivier ROLAND wrote: Both versions are builded from source. head -1 $(git --exec-path)/git-filter-branch #!/bin/sh sh --version GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14) Copyright (C) 2007 Free Software Foundation, Inc.

Re: Bug report : bad filter-branch (OSX only)

2015-04-27 Thread Jeff King
On Sun, Apr 26, 2015 at 11:25:52AM +0200, Olivier ROLAND wrote: OSX 10.10.3 git 2.3.6 HFS+ case-sensitive How to reproduce : Step 1 : git clone https://github.com/begeric/FastParsers.git Step 2 : cd FastParsers/ Step 3 : git filter-branch --env-filter 'if [ 0 = 1 ]; then echo 0; fi' --

Bug report : bad filter-branch (OSX only)

2015-04-26 Thread Olivier ROLAND
Hello, Seem to be a bug. OSX 10.10.3 git 2.3.6 HFS+ case-sensitive How to reproduce : Step 1 : git clone https://github.com/begeric/FastParsers.git Step 2 : cd FastParsers/ Step 3 : git filter-branch --env-filter 'if [ 0 = 1 ]; then echo 0; fi' -- --all Result on OSX : Rewrite