Re: Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

2016-07-11 Thread Junio C Hamano
On Mon, Jul 11, 2016 at 9:27 AM, Nils Fenner wrote: > Hi Santiago, > > repeated your test here and actually found something interesting. When > committing via 'git gui', commits are not being gpg-signed, while firing > a 'git commit' shows the passphrase dialog and signs the commit correctly. "gi

Re: Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

2016-07-11 Thread Santiago Torres
On Mon, Jul 11, 2016 at 06:27:57PM +0200, Nils Fenner wrote: > Hi Santiago, > > repeated your test here and actually found something interesting. When > committing via 'git gui', commits are not being gpg-signed, while firing > a 'git commit' shows the passphrase dialog and signs the commit correc

Re: Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

2016-07-11 Thread Nils Fenner
Hi Santiago, repeated your test here and actually found something interesting. When committing via 'git gui', commits are not being gpg-signed, while firing a 'git commit' shows the passphrase dialog and signs the commit correctly. Here's what I did: git init gpg-signing-test && cd gpg-signing-t

Re: Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

2016-07-11 Thread Santiago Torres
Hi Nils, I just checked and I have commits made in 2.9 with this option set and I don't seem to have your issue. Here's what I did: santiago at ~/test-signing ✔ git init Initialized empty Git repository in /home/santiago/test-signing/.git/ santiago at ~/test-signing ✔ hub create U

Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

2016-07-11 Thread Nils Fenner
Hey Git community, since Version 2.9.0, the configuration option "commit.gpgsign" doesn't work as users would expect. By committing via 'git gui' (or usual 'git commit' without further option), commits are not being auto-signed any longer, when "commit.gpgSign" configuration option is set. I