Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> I may get some students to work on this in May, or do it myself one day. > > I envy teachers who can say "hey, code this for me if you want > course credits". Well, in practice it's often still more work to supervise students than to do the wor

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Junio C Hamano
Matthieu Moy writes: > We don't have "procedure" for feature requests. It happens often that > someone dreams aloud like I did above, and it's OK as long as "it > shouldn't be hard to implement" is understood as "one day I should do > it" and not "hey, you lazy devs, why don't you code that for m

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Matthieu Moy
Martine Lenders writes: >> [ Please, don't top-post on this list ] ... and as much as possible keep the "XYZ wrote:" line so that we know who wrote what ;-). I wrote: >> I wish I could write commit messages like >> >> fixup! deadbeef: fix typo (foo -> bar) >> >> So that the commit message conta

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Martine Lenders
> [ Please, don't top-post on this list ] Sorry (*^.^*) > It won't match if you put it in the subject line, but John's proposal is to put it at the bottom (i.e. in the body). This won't disturb "git rebase --autosquash". For some reason I did not even consider the bottom. Tried and it works! Tha

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Matthieu Moy
Martine Lenders writes: > Hi John, > yes, it can be anywhere in the commit message and I already thought > about using a hook for generating the commit message too, but the > problem is then, that `git rebase` won't pair up the commit for > squashing/fixing up with the original commit. It won't

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Matthieu Moy
[ Please, don't top-post on this list ] Martine Lenders writes: > Hi Matthieu, > We already do this :-). But sadly, this won't help: [ci skip] > encourages Travis-CI to do nothing at all, while your proposed > solution will at least require Travis to boot up a VM (or in case of a > build matrix

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread John Keeping
[please don't top post on this list] On Thu, Mar 03, 2016 at 03:33:34PM +0100, Martine Lenders wrote: > yes, it can be anywhere in the commit message and I already thought > about using a hook for generating the commit message too, but the > problem is then, that `git rebase` won't pair up the com

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Martine Lenders
Hi Matthieu, We already do this :-). But sadly, this won't help: [ci skip] encourages Travis-CI to do nothing at all, while your proposed solution will at least require Travis to boot up a VM (or in case of a build matrix several VMs). In our case, including queueing this can take up to 1h. Just i

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Martine Lenders
Hi John, yes, it can be anywhere in the commit message and I already thought about using a hook for generating the commit message too, but the problem is then, that `git rebase` won't pair up the commit for squashing/fixing up with the original commit. Maybe another approach could be to allow for

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Matthieu Moy
John Keeping writes: > On Thu, Mar 03, 2016 at 01:47:00PM +0100, Martine Lenders wrote: >> I'm not sure if this was already requested somewhere (a quick - but >> admittedly not thorough - search did not reveal anything in that >> direction), but I really miss an option to configure the prefixes g

Re: Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread John Keeping
On Thu, Mar 03, 2016 at 01:47:00PM +0100, Martine Lenders wrote: > I'm not sure if this was already requested somewhere (a quick - but > admittedly not thorough - search did not reveal anything in that > direction), but I really miss an option to configure the prefixes generated > by `git commit (-

Feature request: Configurable prefixes for git commit --fixup and --squash

2016-03-03 Thread Martine Lenders
Hi, I'm not sure if this was already requested somewhere (a quick - but admittedly not thorough - search did not reveal anything in that direction), but I really miss an option to configure the prefixes generated by `git commit (--fixup | --squash) ` and picked up by `git rebase -i --autosquash`.