Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-03-11 Thread Junio C Hamano
Jeff King p...@peff.net writes: I'd say keep it at this point. I think there _are_ some good ideas here, and part of a project is figuring out what is good. And part of the role of the mentor is applying some taste. Amen to that. I hope we have enough mentor-candidates with good taste,

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-03-10 Thread Jeff King
On Fri, Feb 28, 2014 at 03:03:52PM +0100, Michael Haggerty wrote: I'm not sure whether it is a good idea or not. But I think it is looking decreasingly like a good GSoC project. I guess I misread the sentiment of the mailing list, because I merged this idea into the list about two hours

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-28 Thread Jeff King
On Thu, Feb 27, 2014 at 01:10:30PM -0500, Brandon McCaig wrote: On Wed, Feb 26, 2014 at 5:52 AM, Jeff King p...@peff.net wrote: This seems like a reasonable feature to me. All of your examples are possible with an edit and another git command, but the convenience may be worth it (though

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-28 Thread Michael Haggerty
On 02/28/2014 01:52 PM, Jeff King wrote: [...] Sorry, I missed an important word in my final sentence. It should have been the examples you gave are NOT particularly interesting to me. On Thu, Feb 27, 2014 at 01:10:30PM -0500, Brandon McCaig wrote: Particularly all of the ideas expressed

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-27 Thread Brandon McCaig
On Wed, Feb 26, 2014 at 5:52 AM, Jeff King p...@peff.net wrote: This seems like a reasonable feature to me. All of your examples are possible with an edit and another git command, but the convenience may be worth it (though personally, most of the examples you gave are particularly interesting

GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Michael Haggerty
I just submitted the idea below as a pull request [1] to the GSoC ideas page, but I'd like to get some mailing list feedback first that the idea is sensible... And, is there anybody else willing to volunteer as a mentor for this project? (There should be at least two.) Michael [1]

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Jeff King
On Wed, Feb 26, 2014 at 09:04:30AM +0100, Michael Haggerty wrote: It would be nice to support more flexibility in the todo-list commands by allowing the commands to take options. Maybe * Convert a commit into a merge commit: pick -p c0ffeee -p e1ee712 deadbab The oneline of the

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Michael Haggerty
On 02/26/2014 11:52 AM, Jeff King wrote: On Wed, Feb 26, 2014 at 09:04:30AM +0100, Michael Haggerty wrote: It would be nice to support more flexibility in the todo-list commands by allowing the commands to take options. Maybe * Convert a commit into a merge commit: pick -p c0ffeee

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Jeff King
On Wed, Feb 26, 2014 at 12:14:11PM +0100, Michael Haggerty wrote: [1] The one feature I would like in this vein is that editing the title in the instruction-sheet would modify the commit message of the relevant commit. For some reason I try to do this every few weeks, but of

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Tay Ray Chuan
On Wed, Feb 26, 2014 at 6:52 PM, Jeff King p...@peff.net wrote: I'd worry a little that it is not a summer's worth of work, but I suspect there are other parts of rebase--interactive that could use attention once the student is familiar with the code. It might be worthwhile to check for prior

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, Feb 26, 2014 at 09:04:30AM +0100, Michael Haggerty wrote: It would be nice to support more flexibility in the todo-list commands by allowing the commands to take options. Maybe * Convert a commit into a merge commit: pick -p c0ffeee -p

Re: GSoC idea: allow git rebase --interactive todo lines to take options

2014-02-26 Thread Michael Haggerty
On 02/26/2014 11:52 AM, Jeff King wrote: On Wed, Feb 26, 2014 at 09:04:30AM +0100, Michael Haggerty wrote: It would be nice to support more flexibility in the todo-list commands by allowing the commands to take options. Maybe * Convert a commit into a merge commit: pick -p c0ffeee