On 7/19/2018 6:26 PM, brian m. carlson wrote:
On Wed, Jul 18, 2018 at 02:18:44PM +0200, Johannes Schindelin wrote:
On Sat, 14 Jul 2018, brian m. carlson wrote:
I will say that at cPanel, we have a configuration where end users can
end up inside a mount namespace without /proc (depending on
On Wed, Jul 18, 2018 at 02:18:44PM +0200, Johannes Schindelin wrote:
> On Sat, 14 Jul 2018, brian m. carlson wrote:
> > I will say that at cPanel, we have a configuration where end users can
> > end up inside a mount namespace without /proc (depending on the
> > preferences of the administrator).
Hi,
[dropping Perry's non-working email address again]
On Sat, 14 Jul 2018, brian m. carlson wrote:
> On Tue, Jul 10, 2018 at 10:03:10AM -0400, Jeff King wrote:
> > My point is that aside from RUNTIME_PREFIX, we don't need /proc. So
> > somebody who currently builds Git with a static path like
Hi Jonathan,
[had to drop Perry Hutchinson, as the email address is apparently invalid,
and I only realized now that I never sent this out.]
On Tue, 10 Jul 2018, Jonathan Nieder wrote:
> If this [/proc issue] is the main obstacle to enabling RUNTIME_PREFIX by
> default, one option would be to
On Tue, Jul 10, 2018 at 10:03:10AM -0400, Jeff King wrote:
> My point is that aside from RUNTIME_PREFIX, we don't need /proc. So
> somebody who currently builds Git with a static path like
> "/usr/libexec/git-core" and runs it inside a chroot will be just fine as
> long as /usr/libexec/git-core is
A quick correction:
Jonathan Nieder wrote:
> Similarly, various features of other tools (like bash's
> support for <(echo hi)) also rely on /proc.
That relies on /dev/fd, not /proc, but same idea.
Tools like "ps" rely on /proc.
Sorry for the noise,
Jonathan
Hi,
Jeff King wrote:
> My point is that aside from RUNTIME_PREFIX, we don't need /proc. So
> somebody who currently builds Git with a static path like
> "/usr/libexec/git-core" and runs it inside a chroot will be just fine as
> long as /usr/libexec/git-core is available at that name inside the
>
Daniel Jacques writes:
> All things considered, I think executable path self-location is markedly more
> fragile than using static paths, both with increased dependencies and added
> inconsistent behavior and limitations, and should not be the default
> on any platform.
>
> Both Johannes'
Perry Hutchison wrote:
> If we need /proc, wouldn't we _already_ be unhappy inside a chroot
> that didn't mount /proc, even _with_ fallback to static paths?
> Last I knew, the whole point of chroots/containers/jails/etc. was to
> prevent access, from a process running inside the container, to any
On Tue, Jul 10, 2018 at 12:13:42AM -0700, Perry Hutchison wrote:
> Jeff King wrote:
>
> > If I understand correctly, the Linux implementation requires reading
> > from /proc. So an executable that only did RUNTIME_PREFIX (with no
> > fallback to static paths) would be unhappy inside a chroot or
Hi Peff,
On Mon, 9 Jul 2018, Jeff King wrote:
> On Mon, Jul 09, 2018 at 10:26:54PM +0200, Johannes Schindelin wrote:
>
> > > Would it be reasonable to make RUNTIME_PREFIX the default on systems
> > > where we _do_ have that support? AFAIK there is no downside to having it
> > > enabled (minus a
Jeff King wrote:
> If I understand correctly, the Linux implementation requires reading
> from /proc. So an executable that only did RUNTIME_PREFIX (with no
> fallback to static paths) would be unhappy inside a chroot or other
> container that didn't mount /proc.
If we need /proc, wouldn't we
On Mon, Jul 09, 2018 at 03:58:22PM -0400, Jeff King wrote:
> On Sun, Jul 08, 2018 at 11:52:22PM +0200, Johannes Schindelin wrote:
>
> > Now, if you care to have a look at Dan's (and my) patches to implement
> > RUNTIME_PREFIX so that it looks for a directory *relative to the Git
> > binary*, you
On Mon, Jul 09, 2018 at 10:26:54PM +0200, Johannes Schindelin wrote:
> > Would it be reasonable to make RUNTIME_PREFIX the default on systems
> > where we _do_ have that support? AFAIK there is no downside to having it
> > enabled (minus a few syscalls to find the prefix, I suppose, but I
> >
Jeff King writes:
> On Sun, Jul 08, 2018 at 11:52:22PM +0200, Johannes Schindelin wrote:
>
>> Now, if you care to have a look at Dan's (and my) patches to implement
>> RUNTIME_PREFIX so that it looks for a directory *relative to the Git
>> binary*, you will see that it is far from portable. In
Hi Peff,
On Mon, 9 Jul 2018, Jeff King wrote:
> On Sun, Jul 08, 2018 at 11:52:22PM +0200, Johannes Schindelin wrote:
>
> > Now, if you care to have a look at Dan's (and my) patches to implement
> > RUNTIME_PREFIX so that it looks for a directory *relative to the Git
> > binary*, you will see
On Sun, Jul 08, 2018 at 11:52:22PM +0200, Johannes Schindelin wrote:
> Now, if you care to have a look at Dan's (and my) patches to implement
> RUNTIME_PREFIX so that it looks for a directory *relative to the Git
> binary*, you will see that it is far from portable. In fact, it is very
>
Hi Paul,
On Sun, 8 Jul 2018, Paul Smith wrote:
> On Fri, 2018-07-06 at 09:18 -0400, Daniel Jacques wrote:
> > I forewent autoconf because I was concerned that the option was too
> > obscure and the configuration too nuanced to be worth adding via
> > flag, as RUNTIME_PREFIX requires some degree
On Fri, 2018-07-06 at 09:18 -0400, Daniel Jacques wrote:
> I forewent autoconf because I was concerned that the option was too
> obscure and the configuration too nuanced to be worth adding via
> flag, as RUNTIME_PREFIX requires some degree of path alignment and is
> fairly special-case. If you
Apologies for the delayed response - I've been out of town - and It
looks like Paul is already on the right track.
Johannes: I believe the GIT_EXEC_PATH snipped that you listed is not
incorrect. It's defined to "gitexecdir_SQ", and RUNTIME_PREFIX expects
(and enforces, as you snipped) that this
Hi Paul,
On Thu, 5 Jul 2018, Paul Smith wrote:
> On Wed, 2018-07-04 at 13:22 +0200, Johannes Schindelin wrote:
> > > Basically what happens is that I run configure with
> > > --prefix=/my/install/path --with-gitconfig=etc/gitconfig
> > > --with-gitattributes=etc/gitattributes.
> > >
> > > Then
On Wed, 2018-07-04 at 13:22 +0200, Johannes Schindelin wrote:
> > Basically what happens is that I run configure with
> > --prefix=/my/install/path --with-gitconfig=etc/gitconfig
> > --with-gitattributes=etc/gitattributes.
> >
> > Then I run make with RUNTIME_PREFIX=YesPlease.
>
> Ah. In Git for
Hi Paul,
On Wed, 4 Jul 2018, Paul Smith wrote:
> I was excited to see the RUNTIME_PREFIX for POSIX systems patchset go
> by earlier this year. Although I didn't see any mention of it being
> included in the 2.18.0 release notes, it does appear that it was merged
> in for this release.
>
> Has
I was excited to see the RUNTIME_PREFIX for POSIX systems patchset go
by earlier this year. Although I didn't see any mention of it being
included in the 2.18.0 release notes, it does appear that it was merged
in for this release.
Has anyone else tried to get it working? It doesn't appear to be
24 matches
Mail list logo
