Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-12-02 Thread Junio C Hamano
Duy Nguyen writes: > ... But let me sleep on it (and everybody please > give ideas if you have any). Meanwhile, maybe reverting d95138e should > be done any way for now. Broken aliases are not as bad as broken > hooks. OK, when/if you decide that our first step should be a

Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-12-01 Thread Duy Nguyen
On Mon, Nov 30, 2015 at 9:16 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >> I was wrong, GIT_WORK_TREE support was added in git-clone many years >> ago in 20ccef4 (make git-clone GIT_WORK_TREE aware - 2007-07-06). So >> my change accidentally triggers

Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-11-30 Thread Duy Nguyen
On Wed, Nov 25, 2015 at 9:13 PM, Duy Nguyen wrote: > On Tue, Nov 24, 2015 at 6:57 PM, Stefan Beller wrote: >> +to Nguyễn Thái Ngọc Duy >> >> On Mon, Nov 23, 2015 at 6:22 PM, Anthony Sottile wrote: >>> * Short

Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-11-30 Thread Junio C Hamano
Duy Nguyen writes: > I was wrong, GIT_WORK_TREE support was added in git-clone many years > ago in 20ccef4 (make git-clone GIT_WORK_TREE aware - 2007-07-06). So > my change accidentally triggers an (undocumented) feature. We could > add a hack to ignore GIT_WORK_TREE if

Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-11-25 Thread Duy Nguyen
On Tue, Nov 24, 2015 at 6:57 PM, Stefan Beller wrote: > +to Nguyễn Thái Ngọc Duy > > On Mon, Nov 23, 2015 at 6:22 PM, Anthony Sottile wrote: >> * Short description of the problem * >> >> It seems GIT_WORK_DIR is now exported invariantly

Re: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-11-24 Thread Stefan Beller
+to Nguyễn Thái Ngọc Duy On Mon, Nov 23, 2015 at 6:22 PM, Anthony Sottile wrote: > * Short description of the problem * > > It seems GIT_WORK_DIR is now exported invariantly when calling git > hooks such as pre-commit. If these hooks involve cloning

Fwd: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6)

2015-11-23 Thread Anthony Sottile
* Short description of the problem * It seems GIT_WORK_DIR is now exported invariantly when calling git hooks such as pre-commit. If these hooks involve cloning repositories they will not fail due to this exported environment variable. This was not the case in prior versions (such as v2.5.0).