Re: Handling of paths

2017-07-24 Thread Jeff King
On Fri, Jul 21, 2017 at 08:15:17AM -0700, Junio C Hamano wrote: > In general, I (and other experienced reviewers here) prefer to give > chances to people who are new to the Git development community and > are inclined to do so to scratch their own itch, by giving analysis > of the problem and a su

Re: Handling of paths

2017-07-21 Thread Junio C Hamano
Victor Toni writes: > 2017-07-20 22:30 GMT+02:00 Junio C Hamano : >> >> I've read the function again and I think the attached patch covers >> everything that ought to be a filename. >> > Your swift reaction is very much appreciated. > With the background you gave I just started to to create a pat

Re: Handling of paths

2017-07-20 Thread Victor Toni
2017-07-20 22:30 GMT+02:00 Junio C Hamano : > > I've read the function again and I think the attached patch covers > everything that ought to be a filename. > Your swift reaction is very much appreciated. With the background you gave I just started to to create a patch myself just to see that you a

Re: Handling of paths

2017-07-20 Thread Charles Bailey
On Thu, Jul 20, 2017 at 01:30:52PM -0700, Junio C Hamano wrote: > > I've read the function again and I think the attached patch covers > everything that ought to be a filename. > > By the way, to credit you, do you prefer your bloomberg or hashpling > address? The patch looks good to me. It's n

Re: Handling of paths

2017-07-20 Thread Junio C Hamano
Charles Bailey writes: > On Thu, Jul 20, 2017 at 12:42:40PM -0700, Junio C Hamano wrote: >> Victor Toni writes: >> >> > What's unexpected is that paths used for sslKey or sslCert are treated >> > differently insofar as they are expected to be absolute. >> > Relative paths (whether with or witho

Re: Handling of paths

2017-07-20 Thread Charles Bailey
On Thu, Jul 20, 2017 at 12:42:40PM -0700, Junio C Hamano wrote: > Victor Toni writes: > > > What's unexpected is that paths used for sslKey or sslCert are treated > > differently insofar as they are expected to be absolute. > > Relative paths (whether with or without "~") don't work. > > It appe

Re: Handling of paths

2017-07-20 Thread Junio C Hamano
Victor Toni writes: > What's unexpected is that paths used for sslKey or sslCert are treated > differently insofar as they are expected to be absolute. > Relative paths (whether with or without "~") don't work. Looking at http.c::http_options(), I see that "sslcapath" and "sslcainfo" do use git_

Handling of paths

2017-07-19 Thread Victor Toni
Hello, I have a .gitconfig in which I try to separate work and private stuff by using includes which works great. When using [include] the path is treated either - relative to the including file (if the path itself relative) - relative to the home directory if it starts with ~ - absolute if the p