Re: Is NO_ICONV misnamed or is it broken?

2018-06-16 Thread Eric Sunshine
On Sat, Jun 16, 2018 at 10:57 PM Christian Couder wrote: > On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi > wrote: > > ~> make NO_ICONV=1 > > # ommitted > > LINK git-credential-store > > /usr/bin/ld: cannot find -liconv > I think 597c9cc540 (Flatten tools/ directory to make build

Re: Is NO_ICONV misnamed or is it broken?

2018-06-16 Thread Christian Couder
Hi, On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi wrote: > Hello list, > > With regards to the Makefile define/variable `NO_ICONV` - the Makefile > comments imply that it should be used if "your libc doesn't properly support > iconv," which could mean anything from "a patch will be applied"

Is NO_ICONV misnamed or is it broken?

2018-06-14 Thread Mahmoud Al-Qudsi
Hello list, With regards to the Makefile define/variable `NO_ICONV` - the Makefile comments imply that it should be used if "your libc doesn't properly support iconv," which could mean anything from "a patch will be applied" to "iconv won't be used." Based off the name of the varibale, the