RE: Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

2017-09-29 Thread Johannes Schindelin
ce to read up on the context ] > Wesley Smith > T: 503.597.0556 | wsm...@greatergiving.com > > -Original Message- > From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Thursday, September 14, 2017 11:51 PM > To: Wesley Smith > Cc: git@vger.kernel.org > Subj

RE: Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

2017-09-15 Thread Wesley Smith
ernel.org Subject: Re: Is finalize_object_file in sha1_file.c handling errno from "rename" correctly? Wesley Smith writes: > 1) This bug is triggered because "git fetch" is causing a pack file to > be written when that same pack file already exists. It seems like > th

Re: Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

2017-09-14 Thread Junio C Hamano
Wesley Smith writes: > 1) This bug is triggered because "git fetch" is causing a pack > file to be written when that same pack file already exists. It > seems like this is harmless and shouldn't cause a problem. Is > that correct? The final name of the packfile is derived from the entire conte

Is finalize_object_file in sha1_file.c handling errno from "rename" correctly?

2017-09-14 Thread Wesley Smith
Using git 2.14.1 for Windows I'm seeing an issue with the follow sequence of commands: git init D:\XXX\workspace git fetch --no-tags --progress https://XXX/_git/PAPI +refs/heads/*:refs/remotes/origin/* --depth=20 git fetch --no-tags --progress https://XXX/_git/PAPI +refs/heads/*:refs/remotes/o