On Mon, Aug 24, 2015 at 01:43:27AM -0400, Jeff King wrote:
I wonder if alias_lookup() and check_pager_config(), two functions
that *know* that the string they have, cmd, could be invalid and
unusable key to give to the config API, should be doing an extra
effort (e.g. call parse_key()
Jeff King p...@peff.net writes:
Yeah, I agree these are the only two sane fixes. Plumbing the quiet flag
through does seem really invasive; every git_config_get_foo variant
would have to learn it. Probably it's too gross to have a global like:
config_lax_mode = 1;
On Fri, Aug 21, 2015 at 03:13:38PM -0700, Junio C Hamano wrote:
diff --git a/config.c b/config.c
index 9fd275f..dd0cb52 100644
--- a/config.c
+++ b/config.c
@@ -1314,7 +1314,7 @@ static struct config_set_element
*configset_find_element(struct config_set *cs,
* `key` may come
On Fri, Aug 21, 2015 at 09:10:35AM -0700, Junio C Hamano wrote:
$ git \#fetch
error: invalid key: pager.#fetch
error: invalid key: alias.#fetch
git: '#fetch' is not a git command. See 'git --help'.
Did you mean this?
fetch
Thanks. I somehow thought that we had some
Bjørnar Snoksrud snoks...@gmail.com writes:
If you mis-type a git command starting with a non-letter, git
internals will spit out some errors at you.
$ git 5fetch
error: invalid key: pager.5fetch
error: invalid key: alias.5fetch
git: '5fetch' is not a git command. See 'git --help'.
Did
Jeff King p...@peff.net writes:
I think the plan is:
1. squelch the warning message from the config code; even if we change
the config format to pager.*.command, we will have to support
pager.* for historical reasons.
2. introduce pager.*.command so that git foo_bar can use
If you mis-type a git command starting with a non-letter, git
internals will spit out some errors at you.
$ git 5fetch
error: invalid key: pager.5fetch
error: invalid key: alias.5fetch
git: '5fetch' is not a git command. See 'git --help'.
Did you mean this?
fetch
$ git \#fetch
error:
7 matches
Mail list logo
