Re: Null pointer dereference in git-submodule

2018-03-28 Thread Stefan Beller
On Wed, Mar 28, 2018 at 9:52 AM, Junio C Hamano wrote: > Stefan Beller writes: > >>> Subject: [PATCH v2] submodule: check for NULL return of >> get_submodule_ref_store() >> >> Maybe more imperative, telling what we actually want >> to achieve instead of

Re: Null pointer dereference in git-submodule

2018-03-28 Thread Junio C Hamano
Stefan Beller writes: >> Subject: [PATCH v2] submodule: check for NULL return of > get_submodule_ref_store() > > Maybe more imperative, telling what we actually want > to achieve instead of what we do? > >submodule: report deleted submodules as not initialized > >> If we

Re: Null pointer dereference in git-submodule

2018-03-27 Thread Stefan Beller
On Sun, Mar 25, 2018 at 3:58 AM René Scharfe wrote: > Am 25.03.2018 um 11:50 schrieb Jeremy Feusi: > > > > Hmm... That's weird. I can reproduce it on 3 independant systems with > > versions 2.16.2 up, although it does not work with version 2.11.0. > > Anyway, I figured out how to

Re: Null pointer dereference in git-submodule

2018-03-25 Thread René Scharfe
Am 25.03.2018 um 11:50 schrieb Jeremy Feusi: > > Hmm... That's weird. I can reproduce it on 3 independant systems with > versions 2.16.2 up, although it does not work with version 2.11.0. > Anyway, I figured out how to reproduce this bug. It is caused when a > submodule is added and then the

Re: Null pointer dereference in git-submodule

2018-03-25 Thread Jeremy Feusi
Reply-To: Hmm... That's weird. I can reproduce it on 3 independant systems with versions 2.16.2 up, although it does not work with version 2.11.0. Anyway, I figured out how to reproduce this bug. It is caused when a submodule is added and then the directory it resides in is moved or deleted

Re: Null pointer dereference in git-submodule

2018-03-24 Thread René Scharfe
Am 24.03.2018 um 18:42 schrieb Jeremy Feusi: > Hi, > While bootstrapping a gnu repository I noticed that git segfaulted when > called as "git submodule status". After compiling git with address > sanitizer and minimizing the directory I finally narrowed it down to the > files which I have attached

Null pointer dereference in git-submodule

2018-03-24 Thread Jeremy Feusi
Hi, While bootstrapping a gnu repository I noticed that git segfaulted when called as "git submodule status". After compiling git with address sanitizer and minimizing the directory I finally narrowed it down to the files which I have attached as a tar archive. Here is a detailed backtrace: