[PATCH 0/2] Missing O_NONBLOCK under Windows (was: git.git as of tonight)

2015-11-04 Thread Stefan Beller
The first patch is a general fixup as per discussion, the second patch will make Git compile in Windows again (hopefully, not tested) The number of #ifdefs seems acceptable to me, opinions on that? This has been developed on top of d075d2604c0f9 (Merge branch 'rs/daemon-plug-child-leak' into sb/

Re: O_NONBLOCK under Windows (was: git.git as of tonight)

2015-11-04 Thread Stefan Beller
On Wed, Nov 4, 2015 at 11:59 AM, Torsten Bögershausen wrote: > On 11/04/2015 12:00 AM, Stefan Beller wrote: >> On Tue, Nov 3, 2015 at 1:03 PM, Johannes Sixt wrote: >> > The #ifdef assumes that Windows never will have O_NONBLOCK/F_GETFL) > > Does the following make more sense ? > #if defined (O_NO

Re: O_NONBLOCK under Windows (was: git.git as of tonight)

2015-11-04 Thread Torsten Bögershausen
On 11/04/2015 12:00 AM, Stefan Beller wrote: > On Tue, Nov 3, 2015 at 1:03 PM, Johannes Sixt wrote: > The #ifdef assumes that Windows never will have O_NONBLOCK/F_GETFL) Does the following make more sense ? #if defined (O_NONBLOCK) && defined (F_GETFL) Or may be: #ifndef NO_O_NONBLOCK >> #ifndef