Occasional wrong behavior of rev-walking (rev-list, log, etc.)

2015-05-21 Thread Mike Hommey
Hi, I noticed that in some weird cases, git rev-list and friends would appear to not do their work as intended. As I wasn't entirely sure at the time I saw previous occurrence (which involved lots of refs and big history) , I kept that on the side to look back later, but today, it happened again

Re: Occasional wrong behavior of rev-walking (rev-list, log, etc.)

2015-05-21 Thread Mike Hommey
On Thu, May 21, 2015 at 09:41:55AM -0700, Junio C Hamano wrote: Mike Hommey m...@glandium.org writes: My guess is that rev-walking is tripping on the fact that this repository has commit dates in random order. Yeah, that is well known (look for SLOP both in the code and list archive).

Re: Occasional wrong behavior of rev-walking (rev-list, log, etc.)

2015-05-21 Thread Junio C Hamano
Depends on why you are running rev-list. If you want to know if one commit is contained in another, the way that should work the most reliably is to use merge-base, as the traversal engine of that command was written not to trust the commit timestamps but go with the topology alone. (pardon

Re: Occasional wrong behavior of rev-walking (rev-list, log, etc.)

2015-05-21 Thread Mike Hommey
On Thu, May 21, 2015 at 03:59:48PM -0700, Junio C Hamano wrote: Depends on why you are running rev-list. If you want to know if one commit is contained in another, the way that should work the most reliably is to use merge-base, as the traversal engine of that command was written not to

Re: Occasional wrong behavior of rev-walking (rev-list, log, etc.)

2015-05-21 Thread Junio C Hamano
Mike Hommey m...@glandium.org writes: My guess is that rev-walking is tripping on the fact that this repository has commit dates in random order. Yeah, that is well known (look for SLOP both in the code and list archive). -- To unsubscribe from this list: send the line unsubscribe git in the