Re: Odd git overrflow bug?

2016-07-10 Thread Junio C Hamano
On Sun, Jul 10, 2016 at 2:29 PM, Linus Torvalds wrote: > On Sun, Jul 10, 2016 at 2:21 PM, Linus Torvalds > wrote: >> >> I'm not sure why it doesn't happen in current git master, because that >> function is the same, and the logic

Re: Odd git overrflow bug?

2016-07-10 Thread Linus Torvalds
On Sun, Jul 10, 2016 at 2:21 PM, Linus Torvalds wrote: > > I'm not sure why it doesn't happen in current git master, because that > function is the same, and the logic around expand_tabs_in_log looks > similar too. Ahh. Commit 43ec55091553 ("bisect: always call

Re: Odd git overrflow bug?

2016-07-10 Thread Linus Torvalds
On Sun, Jul 10, 2016 at 2:05 PM, Linus Torvalds wrote: > > I'm getting "extra" being -1 in strbuf_grow(). Let me dog deeper. "dog deeper"? My typing skills are deteriorating. Anyway, I dug deeper, and the reason is that "tabwidth" is -1, and then pretty.c:1669:

Re: Odd git overrflow bug?

2016-07-10 Thread Linus Torvalds
On Sun, Jul 10, 2016 at 2:01 PM, Linus Torvalds wrote: > > I'll try to figure out why git-2.9.0 fails. I'm getting "extra" being -1 in strbuf_grow(). Let me dog deeper. Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body

Re: Odd git overrflow bug?

2016-07-10 Thread Linus Torvalds
On Sun, Jul 10, 2016 at 11:41 AM, Andreas Schwab wrote: > > I've seen that too, but only at the end of bisection, when it tries to > display the bad commit. That's apparently what the kernel bug reporter sees too now. However, I cannot reproduce the problem with the

Re: Odd git overrflow bug?

2016-07-10 Thread Andreas Schwab
Linus Torvalds writes: > We have an odd bug report in the kernel, where somebody had trouble > bisecting all the way due to > > "git is failing with "you are trying to use to much memory"(?!)" > > which can't be an exact error message quote, but the closest I

Odd git overrflow bug?

2016-07-10 Thread Linus Torvalds
We have an odd bug report in the kernel, where somebody had trouble bisecting all the way due to "git is failing with "you are trying to use to much memory"(?!)" which can't be an exact error message quote, but the closest I can find smells like the "unsigned_add_overflows()" check in the